Azure Defender EASM Public Preview #26755
Conversation
shadahmed-microsoft
requested review from
bterlson,
ckairen,
deyaaeldeen,
jeremymeng,
mikeharder,
witemple-msft and
xirzec
as code owners
| }, | ||
| { | ||
| "packageName": "@azure-rest/defender-easm", | ||
| "projectFolder": "sdk/easm/defender-easm", |
There was a problem hiding this comment.
we need to suffix the folder with -rest
|
@joheredi, shadahmed is no longer working for microsoft, is it possible for me to contribute to this PR instead? |
Since the source of this PR is a branch in this repository, I think you should be able to push to it if you want to take over this PR? Let me know if you have permission issues and we can try to sort them out. |
|
Hi @xirzec, I'm taking this PR over this sprint, and I don't have permission to push changes. Can you provide me with steps to get the permissions? Thank you |
I think it might be easiest for you to clone the branch and open a new PR since I think the permissions for contributors get a little strange. Would you mind doing that? You may have to create a fork if it won't let you create a local branch, you can find out more instructions here: https://github.com/Azure/azure-sdk-for-js/blob/main/CONTRIBUTING.md |
|
Cool, I will create another PR and associate the issue with it |
[product documentation](https://learn.microsoft.com/en-us/azure/external-attack-surface-management/) Azure/azure-sdk#5062 Typespec PR: Azure/azure-rest-api-specs#24937 arcboard: Azure/azure-sdk#5062 apiview: https://apiview.dev/Assemblies/Review/03ef0c5f65374c3789d8302ef5c9c570 ### Packages impacted by this PR ### Issues associated with this PR Azure SDK Review issue: Azure/azure-sdk-pr#1276 Azure SDK Introducing issue: Azure/azure-sdk#5062 ### Describe the problem that is addressed by this PR Adding a new JavaScript data-plane sdk for EASM service ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes, test cases are added ### Provide a list of related PRs _(if any)_ - Previous PR: #26755. It was closed because Shad is no longer working for Microsoft and other developers don't have access to push to that PR. ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ Used npx tsp complile to generate the PR ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Packages impacted by this PR
@azure-rest/defender-easm
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR is for the onboarding of the Defender EASM SDK into the javascript repo.
product documentation
introductory session ticket
Typespec PR: Azure/azure-rest-api-specs#24937
arcboard: Azure/azure-sdk#5062
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes, test cases have been added for each operation offered by the rest client.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists