Skip to content

js - pullrequest #31420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 98 commits into from
Nov 1, 2024
Merged

js - pullrequest #31420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
03e9f7c
preliminary changes to build
scbedd Oct 2, 2024
f6352dc
pulling across the improvements from original pipelinev3 branch
scbedd Oct 2, 2024
dccd0f9
fix the pullrequest caller for proper relative path
scbedd Oct 2, 2024
cf03790
is this better?
scbedd Oct 2, 2024
4c683df
handle nonexisting service when invoking for PR
scbedd Oct 2, 2024
2cb2a7b
script -> pwsh
scbedd Oct 2, 2024
6295825
fix rush runner
scbedd Oct 2, 2024
dd73653
swap from from to to when multiple services are provided
scbedd Oct 2, 2024
e750488
iterating across all the artifacts for a prdiff
scbedd Oct 2, 2024
725c6a7
working my way through the crashing build
scbedd Oct 3, 2024
733b020
we need to pass PackagePropertiesFolder not PackageInfoFolder
scbedd Oct 3, 2024
3bf5519
fix documentation run
scbedd Oct 3, 2024
61aee6d
need to pass the service to each one
scbedd Oct 3, 2024
cd78bea
$(Build.ArtifactStagingDirectory -> $(Build.ArtifactStagingDirectory)
scbedd Oct 3, 2024
b6d50de
artifactName -> artifact
scbedd Oct 3, 2024
b913f2e
pull across the artifact changes from the tools PR. use in analyze phase
scbedd Oct 10, 2024
6daa9b0
pass the package info folder in analyze
scbedd Oct 10, 2024
741a3c7
repair the calls to resolve-package-artifacts
scbedd Oct 10, 2024
f651fd1
update everywhere that we utilize ServiceDirectory with changedServic…
scbedd Oct 10, 2024
5cb6786
update analyze usage to pass changed services
scbedd Oct 10, 2024
d0f58a5
update to consume packageinfo instead of artifact list for set-artifa…
scbedd Oct 10, 2024
063520a
Merge branch 'main' into pipelinev3-v2
scbedd Oct 10, 2024
e52aba6
actually, pass it --only?
scbedd Oct 11, 2024
0d0034c
upate rush-runner to invoke --to when handling core changes, otherwis…
scbedd Oct 15, 2024
c5a6059
ensure that our new logic doesn't get activated in other service dire…
scbedd Oct 15, 2024
b5a6a65
add servicedirectoryfilter param
scbedd Oct 16, 2024
16fd9e1
fix issue with language-settings
scbedd Oct 16, 2024
da96d77
Merge branch 'main' into pipelinev3-v2
scbedd Oct 16, 2024
ece0dbf
we need to set the property of package-props. AdditionalPackages does…
scbedd Oct 16, 2024
1b23867
save ChangedServices dynamically
scbedd Oct 16, 2024
2626172
resolve changedServiced from the packageProperties files, instead of …
scbedd Oct 16, 2024
48cb9cf
resolve all the arguments here
scbedd Oct 16, 2024
ddba884
standardizing some of the code, we don't need two separate handles wh…
scbedd Oct 16, 2024
83464d4
update all of analyze for non-service-specific check
scbedd Oct 16, 2024
a3f2366
update this thing to allow non-sdk changes to still trigger properly
scbedd Oct 16, 2024
4722a54
changedServices -> $changedServices
scbedd Oct 16, 2024
4a7d646
ensure the argument is surrounded in quotes
scbedd Oct 16, 2024
b072794
fix spelling warnings
scbedd Oct 16, 2024
aa7643f
update step name
scbedd Oct 16, 2024
d0d2f1f
we weren't passing the correct package names
scbedd Oct 16, 2024
0ce2151
updating to handle the split between mgmt and not
scbedd Oct 18, 2024
07d47dc
merge main so we're not changing upstream anymore
scbedd Oct 18, 2024
1c6218b
flatten to what's in main
scbedd Oct 18, 2024
7398926
remove trailing space
scbedd Oct 18, 2024
d503e4b
fix ChangedServices on the fly
scbedd Oct 18, 2024
36140a4
remove unnecessary parameter ServiceDirectoryFilter it is hardcoded
scbedd Oct 18, 2024
2166d3b
try using double quotes instead of single, does that work?
scbedd Oct 22, 2024
01b5822
update to the runtime expression
scbedd Oct 22, 2024
37c1084
adjust the issue with verify-samples
scbedd Oct 22, 2024
599bf6e
CommaChangedServices def
scbedd Oct 22, 2024
53f5ef8
handle the specific --to vs --from requests
scbedd Oct 22, 2024
eb37ef5
ensure that we flatten to an actual array
scbedd Oct 22, 2024
8ecf061
get rid of usage of flat() in favor of simpler getPackagesWithDirection
scbedd Oct 22, 2024
2dc4112
we now split up --to vs --from
scbedd Oct 22, 2024
0805b60
directional updates
scbedd Oct 22, 2024
64f581e
clean up some comments and console logs from rush-runner.js
scbedd Oct 22, 2024
86f4dd6
clean up rushRunAllWithDirection
scbedd Oct 22, 2024
966ae33
Merge branch 'main' into pipelinev3-v2
scbedd Oct 22, 2024
b70cd1f
cleaning up
scbedd Oct 22, 2024
c69371b
we were snapping the targeted packages too soon!
scbedd Oct 23, 2024
e2ceb92
initial version of distributing packages to the matrix. still buggy f…
scbedd Oct 23, 2024
abbff35
add package distribution to the matrix
scbedd Oct 23, 2024
7dc60ba
splatting should be working. just need to ensure multiple batches are…
scbedd Oct 23, 2024
6adb684
ensure that we are able to scan for the packages
scbedd Oct 23, 2024
795a98a
restore accidentally changed matrix
scbedd Oct 23, 2024
3a975b6
update our service resolution logic to handle the ArtifactPackageName…
scbedd Oct 23, 2024
37d47de
ensure the cspell config is pulled across
scbedd Oct 23, 2024
f02bcf2
remove useless set-artifact-packages call. update variable reference
scbedd Oct 23, 2024
8a4fea9
Apply suggestions from code review
scbedd Oct 23, 2024
25c20ae
ensure we pass servicedirectory to the test job. resolve the issue wi…
scbedd Oct 23, 2024
ea53757
clean up changed service output
scbedd Oct 23, 2024
72b7401
actually remove the branch ref
scbedd Oct 25, 2024
191c749
rely on some heavier usage of common parlance
scbedd Oct 25, 2024
0f20711
we need PostGenerationScript to be optional
scbedd Oct 25, 2024
72db8de
simplify the matrix update
scbedd Oct 25, 2024
3af6f36
merge main to resolve merge conflict
scbedd Oct 25, 2024
94ba6b5
add some additional output
scbedd Oct 25, 2024
9aa8fac
dump the output right before using it
scbedd Oct 25, 2024
4f67fe6
remove useless check for engChanged when it is encapsulated by 'other…
scbedd Oct 25, 2024
2a0391e
add cmdlet binding
scbedd Oct 25, 2024
2996fdf
dramatically simplify the call to distribute packages to matrix
scbedd Oct 25, 2024
e75d156
and now that it will actually invoke the script, add back in the call…
scbedd Oct 25, 2024
1248bca
one attempt using no write-hosts or strict mode
scbedd Oct 25, 2024
5d831c9
remove weirdness...I think this was breaking somehow behind the scenes
scbedd Oct 25, 2024
3a09472
disable everything except a single write host
scbedd Oct 25, 2024
7b64344
now remove the Write-Host
scbedd Oct 25, 2024
16cd6b3
removing the write-host solved the problem. time to dump the variable…
scbedd Oct 25, 2024
cd50e71
try re-enabling and referencing a real environment setting
scbedd Oct 25, 2024
909c5b7
fix the batch save
scbedd Oct 26, 2024
e9e0e82
the parameter input MUST be a string, not an array[] type
scbedd Oct 26, 2024
1609ea3
merge main
scbedd Oct 31, 2024
cddda7f
now remove the distribute-packages-to-matrix
scbedd Oct 31, 2024
f0172ed
restore eng/common to main
scbedd Oct 31, 2024
0799806
fix the platform matrix back to main version
scbedd Oct 31, 2024
1c2891d
Merge branch 'main' into pipelinev3-v2
scbedd Oct 31, 2024
6dda23d
resolve the issue with the artifactpackagenames
scbedd Oct 31, 2024
d67e2f9
remove erroneously added audit step
scbedd Oct 31, 2024
37a4dbc
Merge branch 'main' into pipelinev3-v2
scbedd Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure that our new logic doesn't get activated in other service dire… 
…ctories that are running as normal
  • Loading branch information
@scbedd
scbedd committed Oct 15, 2024
commit c5a6059bf1f0369dfc4db6a9acb459c824665e1f
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/save-package-properties.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ parameters:
default: eng/common/scripts

steps:
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
- ${{ if and(eq(variables['Build.Reason'], 'PullRequest'), or(eq(parameters.ServiceDirectoryFilter, ''), eq(parameters.ServiceDirectory, parameters.ServiceDirectoryFilter))) }}:
- task: Powershell@2
displayName: Generate PR Diff
inputs:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ steps:
- template: /eng/common/pipelines/templates/steps/save-package-properties.yml
parameters:
ServiceDirectory: ${{parameters.ServiceDirectory}}
ServiceDirectoryFilter: 'auto'

- template: /eng/common/pipelines/templates/steps/check-spelling.yml

Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ steps:
- template: /eng/common/pipelines/templates/steps/save-package-properties.yml
Copy link
Member Author

@scbedd scbedd Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save-package-properties.yml will call Save-Package-Properties.ps1 with appropriate -AddDevVersion by honoring the SetDevVersion set above in daily-dev-build-variable.yml

parameters:
ServiceDirectory: ${{parameters.ServiceDirectory}}
ServiceDirectoryFilter: 'auto'

- script: |
node common/scripts/install-run-rush.js install
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ steps:
- template: /eng/common/pipelines/templates/steps/save-package-properties.yml
parameters:
ServiceDirectory: ${{parameters.ServiceDirectory}}
ServiceDirectoryFilter: 'auto'

- script: |
node common/scripts/install-run-rush.js install
Expand Down