Skip to content

Conversation

@kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Jun 11, 2025

Copilot AI review requested due to automatic review settings June 11, 2025 09:26
@kazrael2119 kazrael2119 requested review from a team, MaryGao and qiaozha as code owners June 11, 2025 09:26
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the DNS Resolver management SDK release by updating sample functions, revising x‑ms‑original‑file references to stable API versions, and refining API type definitions.

  • Updated sample implementations to support both bulk and less-than-1000 domain scenarios
  • Revised API documentation and type exports in arm-dnsresolver.api.md
  • Bumped the package version and updated dependency versions

Reviewed Changes

Copilot reviewed 209 out of 209 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsResolverDomainListsGetSample.ts Added and renamed sample functions for different domain list scenarios
sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsResolverDomainListsDeleteSample.ts Updated API file references for delete operation
sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsResolverDomainListsCreateOrUpdateSample.ts Added dual function variants for domain list upsert based on domain count
sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsResolverDomainListsBulkSample.ts Introduced bulk upload/download samples for domain lists
sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsForwardingRulesets* Updated API operations and sample functions for forwarding rulesets
sdk/dnsresolver/arm-dnsresolver/review/arm-dnsresolver.api.md Updated type export names and API definitions to reflect new design
sdk/dnsresolver/arm-dnsresolver/package.json Bumped version to 2.0.0 and updated dependency versions
sdk/dnsresolver/arm-dnsresolver/CHANGELOG.md Documented feature additions and breaking changes
Comments suppressed due to low confidence (2)

sdk/dnsresolver/arm-dnsresolver/samples-dev/dnsForwardingRulesetsDeleteSample.ts:25

  • The sample variable name for the DNS forwarding ruleset appears inconsistent with other samples; consider renaming it to 'sampleDnsForwardingRuleset' for improved consistency.
const dnsForwardingRulesetName = "samplednsForwardingRulesetName";

sdk/dnsresolver/arm-dnsresolver/review/arm-dnsresolver.api.md:14

  • There is an inconsistency in the type exports where 'Action' is defined in one place and later 'ActionType' is reintroduced; consider unifying these type names to avoid confusion in the API.
export type Action = string;

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-dnsresolver

@MaryGao MaryGao enabled auto-merge (squash) June 24, 2025 09:22
@MaryGao MaryGao merged commit d92f4d9 into Azure:main Jun 24, 2025
13 checks passed
@kazrael2119 kazrael2119 deleted the dnsresolver-re branch June 24, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants