[BUG] [Storage] [DataMovement] Local folder uploaded to Blob target contains extra subfolder

[tomikiss]

Library name and version

Azure.Storage.DataMovement.Blobs 12.2.1

Describe the bug

Hi,

When using storage data movements with local directory to BlobStorage the target blob storage contains an extra subdirectory called a or ta (randomly).

Expected behavior

All file created to a target path in container no subfolder created

Actual behavior

Extra subfolder created which named normally a or ta, if the target path has trailing slash folder created called

Reproduction Steps

Create a folder called debug with 2 files
Set target upload to be a subfolder on the container
Target container has an extra subdirectory - instead of the files from the source directory.

`
var transferManager = new TransferManager(new TransferManagerOptions()
{
CheckpointStoreOptions = TransferCheckpointStoreOptions.DisableCheckpoint(),
Diagnostics = { IsLoggingEnabled = true}
}));

var transferOptions = new TransferOptions()
{
CreationMode = StorageResourceCreationMode.OverwriteIfExists,
};

var blobContainerOptions = new BlobStorageResourceContainerOptions()
{
BlobPrefix = "subfolder-1/subfolder-2",
BlobType = BlobType.Block
};

var blobContainerClient = new BlobServiceClient('URI-here', new DefaultAzureCredential());

StorageResource blobDirectory = BlobsStorageResourceProvider.FromClient(blobContainerClient, blobContainerOptions);
StorageResource localDirectory = LocalFilesStorageResourceProvider.FromDirectory("debug");

TransferOperation transfer = await transferManager.StartTransferAsync(
localDirectory,
blobDirectory,
transferOptions,
CancellationToken.None).ConfigureAwait(false);

await transfer.WaitForCompletionAsync(CancellationToken.None).ConfigureAwait(false);

`

Environment

.net 9 - 9.0.8

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @amnguye @jalauzon-msft @jaschrep-msft @nickliu-msft @seanmcc-msft.

[tomikiss]

Seems to be the workaround above to use full path
var f2 = Path.GetDirectoryName(Path.GetFullPath(sourceFolder)) - for the local folder which solve the issue and upload where intended, Path.GetFullPath(sourceFolder) will result upload where first character of the filename dropped.

Seems the issue is LocalFilesStorageResourceProvider - and TransferJobInternal.cs around here when used path with trailing slash or not-full path:

string path = _sourceResourceContainer.Uri.GetPath(); string stringToUnescape = (string.IsNullOrEmpty(path) ? current.Uri.GetPath() : current.Uri.GetPath().Substring(path.Length + 1)); stringToUnescape = Uri.UnescapeDataString(stringToUnescape);

[jalauzon-msft]

@tomikiss, thanks for the report. We'll look into this and get back to you.