Skip to content

(feat): Implement Modules client #12673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azabbasi merged 18 commits into from
Jun 10, 2020
Merged

(feat): Implement Modules client #12673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9b79574
Implement Modules client
azabbasi Jun 9, 2020
54ce8ed
Update API Design.md
azabbasi Jun 9, 2020
03a0a15
Fix all warnings and make sure solution builds
azabbasi Jun 10, 2020
fe3fffb
Format files
azabbasi Jun 10, 2020
d59e7d7
remove unnecessary code
azabbasi Jun 10, 2020
7cce057
cr comments
azabbasi Jun 10, 2020
ad24b72
reference http response type
azabbasi Jun 10, 2020
2108d2a
update async pagable comments
azabbasi Jun 10, 2020
743404b
update module client summary
azabbasi Jun 10, 2020
10a089f
add link to the summary
azabbasi Jun 10, 2020
6b19d7c
Update Readme to pass code analysys
azabbasi Jun 10, 2020
c6a9f1a
Update README.md
azabbasi Jun 10, 2020
86312b1
Export APIs
azabbasi Jun 10, 2020
8fa846b
make query string constant
azabbasi Jun 10, 2020
b904adc
Update API design md file to reference implementation.
azabbasi Jun 10, 2020
7d9f736
xml comments for protector constructor
azabbasi Jun 10, 2020
c38b517
Update xml comments.
azabbasi Jun 10, 2020
628e9ff
fix typo
azabbasi Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update async pagable comments
  • Loading branch information
@azabbasi
azabbasi committed Jun 10, 2020
commit 2108d2affdf2a05dba1b8b49ca888a99c64f0033
4 changes: 2 additions & 2 deletions sdk/iot/Azure.Iot.Hub.Service/src/DevicesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ public virtual Response<BulkRegistryOperationResponse> DeleteIdentities(
/// </summary>
/// <param name="pageSize">The size of each page to be retrieved from the service. Service may override this size.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A pageable set of device twins.</returns>
/// <returns>A pageable set of device twins <see cref="AsyncPageable{T}"/>.</returns>
public virtual AsyncPageable<TwinData> GetTwinsAsync(int? pageSize = null, CancellationToken cancellationToken = default)
{
async Task<Page<TwinData>> FirstPageFunc(int? pageSizeHint)
Expand Down Expand Up @@ -397,7 +397,7 @@ async Task<Page<TwinData>> NextPageFunc(string nextLink, int? pageSizeHint)
/// </summary>
/// <param name="pageSize">The size of each page to be retrieved from the service. Service may override this size.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A pageable set of device twins.</returns>
/// <returns>A pageable set of device twins <see cref="Pageable{T}"/>.</returns>
public virtual Pageable<TwinData> GetTwins(int? pageSize = null, CancellationToken cancellationToken = default)
{
Page<TwinData> FirstPageFunc(int? pageSizeHint)
Expand Down
4 changes: 2 additions & 2 deletions sdk/iot/Azure.Iot.Hub.Service/src/ModulesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public virtual Response DeleteIdentity(
/// </summary>
/// <param name="pageSize">The size of each page to be retrieved from the service. Service may override this size.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A pageable set of module twins.</returns>
/// <returns>A pageable set of module twins <see cref="AsyncPageable{T}"/>.</returns>
public virtual AsyncPageable<TwinData> GetTwinsAsync(int? pageSize = null, CancellationToken cancellationToken = default)
{
async Task<Page<TwinData>> FirstPageFunc(int? pageSizeHint)
Expand Down Expand Up @@ -194,7 +194,7 @@ async Task<Page<TwinData>> NextPageFunc(string nextLink, int? pageSizeHint)
/// </summary>
/// <param name="pageSize">The size of each page to be retrieved from the service. Service may override this size.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A pageable set of module twins.</returns>
/// <returns>A pageable set of module twins <see cref="Pageable{T}"/>.</returns>
public virtual Pageable<TwinData> GetTwins(int? pageSize = null, CancellationToken cancellationToken = default)
{
Page<TwinData> FirstPageFunc(int? pageSizeHint)
Expand Down