-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Storage] Make OpenWrite work with using keyword #14758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
78abf66
Prepare Storage for release
kasobol-msft e7907a4
pr feedback.
kasobol-msft 58814fc
PR feedback.
kasobol-msft 1286434
pr feedback.
kasobol-msft 324afd0
merge upstream/master
kasobol-msft b216c89
Merge remote-tracking branch 'upstream/master'
kasobol-msft 1c9e87d
Merge remote-tracking branch 'upstream/master'
kasobol-msft 712ecda
Merge remote-tracking branch 'upstream/master'
kasobol-msft ad612b5
merge upstream/master
kasobol-msft 5849bef
master merge
kasobol-msft 1bcba8b
Merge remote-tracking branch 'upstream/master'
kasobol-msft 8a2e048
Merge remote-tracking branch 'upstream/master'
kasobol-msft 1bf033e
Merge remote-tracking branch 'upstream/master'
kasobol-msft b35274e
Merge remote-tracking branch 'upstream/master'
kasobol-msft feb0649
Merge remote-tracking branch 'upstream/master'
kasobol-msft 5974722
Merge remote-tracking branch 'upstream/master'
kasobol-msft 9252944
Merge remote-tracking branch 'upstream/master'
kasobol-msft f90886e
Merge remote-tracking branch 'upstream/master'
kasobol-msft 3b9b259
Merge remote-tracking branch 'upstream/master'
kasobol-msft f97e9bd
Merge remote-tracking branch 'upstream/master'
kasobol-msft ae9d658
make open write work with using.
kasobol-msft 4a24b96
move recordings to right place
kasobol-msft e970ed7
pr feedback.
kasobol-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
782 changes: 782 additions & 0 deletions
782
...ge.Blobs/tests/SessionRecords/AppendBlobClientTests/OpenWriteAsync_NewBlob_WithUsing.json
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider using the new using syntax without brackets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik that would defer disposal till execution exists the method. That would break assertions below.