Sync eng/common directory with azure-sdk-tools for PR 1546 #20261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing the BaseName with a ServiceDirectory that contains a "/", because it is a multiple level path, causes the BaseName initialization code to fail because it doesn't support the validation pattern. In all the known cases we already pass the ResourceGroupName explicitly so don't need to set the BaseName so we can skip the initialization in those cases.
azure-sdk
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
azure-sdk
added
Central-EngSys
weshaggard
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1546 See eng/common workflow