-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Communication] - ALL - Add subscription configuration to tests.yml #20781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
3457e14
063b7c4
04daeda
f648662
47f94c3
17d80b8
783d633
75542ba
080d7c2
addaafd
4d3589e
f874e15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,11 +13,37 @@ | |
| "defaultValue": "communication", | ||
| "type": "string" | ||
| }, | ||
| "communicationServicesEndpointSuffix": { | ||
| "defaultValue": ".communication.azure.com", | ||
| "type": "string" | ||
| }, | ||
| "subscriptionId": { | ||
| "defaultValue": "[subscription().subscriptionId]", | ||
| "type": "string" | ||
| }, | ||
| "testApplicationOid": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "The client OID to grant access to test resources." | ||
| } | ||
| }, | ||
| "tenantId": { | ||
| "type": "String", | ||
|
||
| "metadata": { | ||
| "description": "The tenant id to which the application and resources belong." | ||
| } | ||
| }, | ||
| "testApplicationId": { | ||
| "type": "String", | ||
| "metadata": { | ||
| "description": "The application client id used to run tests." | ||
| } | ||
| }, | ||
| "testApplicationSecret": { | ||
| "type": "String", | ||
| "metadata": { | ||
| "description": "The application client secret used to run tests." | ||
| } | ||
| } | ||
| }, | ||
| "variables": { | ||
|
|
@@ -46,10 +72,26 @@ | |
| } | ||
| ], | ||
| "outputs": { | ||
| "AZURE_TENANT_ID": { | ||
| "type": "string", | ||
| "value": "[parameters('tenantId')]" | ||
| }, | ||
| "AZURE_CLIENT_ID": { | ||
| "type": "string", | ||
| "value": "[parameters('testApplicationId')]" | ||
| }, | ||
| "AZURE_CLIENT_SECRET": { | ||
| "type": "string", | ||
| "value": "[parameters('testApplicationSecret')]" | ||
| }, | ||
| "COMMUNICATION_CONNECTION_STRING": { | ||
| "type": "string", | ||
| "value": "[listKeys(resourceId('Microsoft.Communication/CommunicationServices',variables('uniqueSubDomainName')), '2020-08-20-preview').primaryConnectionString]" | ||
| }, | ||
| "COMMUNICATION_SERVICE_ENDPOINT": { | ||
|
||
| "type": "string", | ||
| "value": "[concat('https://', parameters('baseName'), '-', parameters('endpointPrefix'), parameters('communicationServicesEndpointSuffix'))]" | ||
| }, | ||
| "RESOURCE_GROUP_NAME": { | ||
| "type": "string", | ||
| "value": "[resourceGroup().Name]" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,16 +16,14 @@ extends: | |
| template: ../../eng/pipelines/templates/stages/archetype-sdk-tests.yml | ||
| parameters: | ||
| ServiceDirectory: communication | ||
| Clouds: ACS_Public | ||
| CloudConfig: | ||
| ACS_Public: | ||
| SubscriptionConfiguration: $(sub-config-communication-services-cloud-test-resources) | ||
| Public: | ||
| SubscriptionConfigurations: | ||
| - $(sub-config-azure-cloud-test-resources) | ||
| - $(sub-config-communication-services-cloud-test-resources-test) | ||
|
||
| - $(sub-config-communication-services-cloud-test-resources-net) | ||
| Clouds: Public | ||
| EnvVars: | ||
| AZURE_TENANT_ID: $(COMMUNICATION_TENANT_ID) | ||
| AZURE_CLIENT_ID: $(COMMUNICATION_CLIENT_ID) | ||
| AZURE_CLIENT_SECRET: $(COMMUNICATION_CLIENT_SECRET) | ||
| AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING: $(communication-livetest-connection-string) | ||
| AZURE_PHONE_NUMBER: $(net-communication-livetest-phone-number) | ||
| # SKIP_PHONENUMBER_LIVE_TESTS skips certain phone number tests such as purchase and release | ||
| SKIP_PHONENUMBER_LIVE_TESTS: TRUE | ||
| TEST_PACKAGES_ENABLED: ${{ parameters.TestPackagesEnabled }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed in .net.