-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update botService SDK to use the latest swagger spec from https://github.com/Azure/azure-rest-api-specs/pull/12995 #20955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...service/Microsoft.Azure.Management.BotService/src/Generated/Models/EmailChannelProperties.cs
Show resolved
Hide resolved
...vice/Microsoft.Azure.Management.BotService/src/Generated/Models/FacebookChannelProperties.cs
Show resolved
Hide resolved
...otservice/Microsoft.Azure.Management.BotService/src/Generated/Models/KikChannelProperties.cs
Show resolved
Hide resolved
...rvice/Microsoft.Azure.Management.BotService/src/Generated/Models/MsTeamsChannelProperties.cs
Show resolved
Hide resolved
...rvice/Microsoft.Azure.Management.BotService/src/Generated/Models/MsTeamsChannelProperties.cs
Show resolved
Hide resolved
...otservice/Microsoft.Azure.Management.BotService/src/Generated/Models/SmsChannelProperties.cs
Show resolved
Hide resolved
| /// <param name="isValidated">Whether this channel is validated for the | ||
| /// bot</param> | ||
| public TelegramChannelProperties(string accessToken, bool isEnabled, bool? isValidated = default(bool?)) | ||
| public TelegramChannelProperties(bool isEnabled, string accessToken = default(string), bool? isValidated = default(bool?)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in a breaking change do you have the link to the spec change associated with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add fallback constructor for back compat.
sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/Operations.cs
Show resolved
Hide resolved
| if ((int)_statusCode != 200) | ||
| { | ||
| var ex = new CloudException(string.Format("Operation returned an invalid status code '{0}'", _statusCode)); | ||
| var ex = new ErrorException(string.Format("Operation returned an invalid status code '{0}'", _statusCode)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in a breaking change do you have the link to the spec change associated with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is code auto generated by Autorest. The version of autorest used is 2.0.4417
sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/SdkInfo_AzureBotService.cs
Show resolved
Hide resolved
|
Hi @hailiu2586. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @hailiu2586. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Please open PR in
Draftmode if it is:[ x ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
Hailiu/bot service web app settings azure-rest-api-specs#12995
[ x] I have read the contribution guidelines.
[ x] The pull request does not introduce breaking changes.
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.