[LogicApp Integration Accounts] [Bug Fix] : Code generated as per the latest RP updates. #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration account spec merged as both are in GA. Map and Schema test session records added Updated the SDK package version Updated IntegrationAccount SkuName Code generated for updated swagger spec
|
Hi @pankajsn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Member
|
@pankajsn adding the "Do Not Merge" label until the corresponding Swagger spec has been merged |
…esource definition. Code regenerated with this change and test updated
…red fields and other comments
Member
|
@pankajsn Hey Pankaj, can you update your |
Contributor
Author
|
Updated
From: Cormac McCarthy [mailto:[email protected]]
Sent: Tuesday, February 14, 2017 12:08 PM
To: Azure/azure-sdk-for-net <[email protected]>
Cc: Pankaj Singh Negi <[email protected]>; Mention <[email protected]>
Subject: Re: [Azure/azure-sdk-for-net] [LogicApp Integration Accounts] [Bug Fix] : Code generated as per the latest RP updates. (#2769)
@pankajsn<https://github.com/pankajsn> Hey Pankaj, can you update your generated.cmd file with the swagger spec you are using to generate this SDK? It should be the following link below that includes the commit ID
https://raw.githubusercontent.com/Azure/azure-rest-api-specs/ecc34b75fe5aecebd148b74392b67e85070e0fc5/arm-logic/2016-06-01/swagger/logic.json
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2769 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APZfcy-ea8LJ4miyyCVBFyZoi3TayY6Wks5rcgmhgaJpZM4LyIy5>.
|
Contributor
|
@pankajsn credscan faild, can you check in your test if you have used any password or serviceprincipal secrets. |
Contributor
Author
|
Credscan warnings are fixed. (http://azuresdkci.cloudapp.net/job/sdk-for-net/4440)
From: Abhijeet [mailto:[email protected]]
Sent: Tuesday, February 14, 2017 1:19 PM
To: Azure/azure-sdk-for-net <[email protected]>
Cc: Pankaj Singh Negi <[email protected]>; Mention <[email protected]>
Subject: Re: [Azure/azure-sdk-for-net] [LogicApp Integration Accounts] [Bug Fix] : Code generated as per the latest RP updates. (#2769)
@pankajsn<https://github.com/pankajsn> credscan faild, can you check in your test if you have used any password or serviceprincipal secrets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2769 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APZfc5NnGUud4W3gSYRiBlwGW3tC3Eumks5rcho7gaJpZM4LyIy5>.
|
shahabhijeet
suggested changes
Feb 15, 2017
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "1.0.0", | |||
| "version": "2.0.0", | |||
Contributor
There was a problem hiding this comment.
@pankajsn can you do same version bump in AssemblyInfo.cs in order to be consistent
otherwise looks good.
Contributor
Author
|
fixed
From: Abhijeet [mailto:[email protected]]
Sent: Wednesday, February 15, 2017 8:38 AM
To: Azure/azure-sdk-for-net <[email protected]>
Cc: Pankaj Singh Negi <[email protected]>; Mention <[email protected]>
Subject: Re: [Azure/azure-sdk-for-net] [LogicApp Integration Accounts] [Bug Fix] : Code generated as per the latest RP updates. (#2769)
@shahabhijeet requested changes on this pull request.
________________________________
In src/ResourceManagement/Logic/Microsoft.Azure.Management.Logic/project.json<#2769 (review)>:
@@ -1,5 +1,5 @@
{
- "version": "1.0.0",
+ "version": "2.0.0",
@pankajsn<https://github.com/pankajsn> can you do same version bump in AssemblyInfo.cs in order to be consistent
otherwise looks good.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2769 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APZfc71SNE6PDPM6dgiYgExRfslu8ZETks5rcynlgaJpZM4LyIy5>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure/azure-rest-api-specs#891
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.