-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Change for NodeConfiguration build version feature #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vrdmr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nuget already seems to have 2.0.3. Make it 2.0.4 if this is conflicting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I'll update it to 2.0.4 to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
|
@azuresdkci test this please |
shahabhijeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr add link to hyak spec PR
| --> | ||
| <SdkNuGetPackage Include="Microsoft.Azure.Management.Automation"> | ||
| <PackageVersion>2.0.2</PackageVersion> | ||
| <PackageVersion>2.0.4</PackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr why skip 2.0.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@safeermohammed added a comment to the earlier commit - "Nuget already seems to have 2.0.3. Make it 2.0.4 if this is conflicting". I verified in the Nuget package manager to verify that a 2.0.3 version was published for the Automation.dll, which was released on 3/23/2017. We couldn't find out how was this released (if the code says 2.0.2 is the latest). Thus, to be on a safer side, we bumped it to 2.0.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We see 2.0.3 is already released to nuget. AFAIK we did not release this (Also from Azure repo history 2.0.2 was the last version).
Can we track down how 2.0.3 was released and by who?
https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrdmr @safeermohammed the only option is to see the nuget.org release date and track it by finding the publish jobs that were run around that time.
We are trying to put in more meta data that will allow us to track this much better in the future.
|
Hyak specs PR - https://github.com/Azure/hydra-specs-pr/pull/1397 @shahabhijeet Could you please review this PR? Thanks. |
|
@vrdmr when is Automation moving/updating Swagger/AutoRest version? |
|
@shahabhijeet I have started writing the test-suite for SDK generated by AutoRest branch (Swagger). I transitioned it from @vivlingaiah recently and would be taking it forward. For my changes for NodeConfiguration build versioning, I made changes in both the places. Others in the team are following the suite as well. |
Description
The changes are generated based on the Hydra spec changes done (Commit: https://github.com/Azure/hydra-specs-pr/pull/1397). This adds support for new switch flag to be passed to signal incrementing the build number.
PS: Also adding the change in the spec in Swagger as well. That work is in progress.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.