Skip to content

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Jun 27, 2017

Description

The changes are generated based on the Hydra spec changes done (Commit: https://github.com/Azure/hydra-specs-pr/pull/1397). This adds support for new switch flag to be passed to signal incrementing the build number.

PS: Also adding the change in the spec in Swagger as well. That work is in progress.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msftclas
Copy link

@vrdmr,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuget already seems to have 2.0.3. Make it 2.0.4 if this is conflicting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll update it to 2.0.4 to be safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@shahabhijeet
Copy link
Contributor

@azuresdkci test this please

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrdmr add link to hyak spec PR

-->
<SdkNuGetPackage Include="Microsoft.Azure.Management.Automation">
<PackageVersion>2.0.2</PackageVersion>
<PackageVersion>2.0.4</PackageVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrdmr why skip 2.0.3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safeermohammed added a comment to the earlier commit - "Nuget already seems to have 2.0.3. Make it 2.0.4 if this is conflicting". I verified in the Nuget package manager to verify that a 2.0.3 version was published for the Automation.dll, which was released on 3/23/2017. We couldn't find out how was this released (if the code says 2.0.2 is the latest). Thus, to be on a safer side, we bumped it to 2.0.4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet

We see 2.0.3 is already released to nuget. AFAIK we did not release this (Also from Azure repo history 2.0.2 was the last version).

Can we track down how 2.0.3 was released and by who?

https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrdmr @safeermohammed the only option is to see the nuget.org release date and track it by finding the publish jobs that were run around that time.
We are trying to put in more meta data that will allow us to track this much better in the future.

@vrdmr
Copy link
Member Author

vrdmr commented Jul 5, 2017

Hyak specs PR - https://github.com/Azure/hydra-specs-pr/pull/1397

@shahabhijeet Could you please review this PR? Thanks.

@shahabhijeet
Copy link
Contributor

@vrdmr when is Automation moving/updating Swagger/AutoRest version?
We would like to know the plan moving forward?

@vrdmr
Copy link
Member Author

vrdmr commented Jul 10, 2017

@shahabhijeet I have started writing the test-suite for SDK generated by AutoRest branch (Swagger). I transitioned it from @vivlingaiah recently and would be taking it forward. For my changes for NodeConfiguration build versioning, I made changes in both the places. Others in the team are following the suite as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants