Skip to content

Conversation

@Eva-Xiao
Copy link
Member

@Eva-Xiao Eva-Xiao commented Nov 20, 2017

Description

Azure/azure-rest-api-specs#2016
Azure/azure-rest-api-specs#1995

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet
Copy link
Contributor

@Eva-Xiao resolve merge conflicts

@Eva-Xiao
Copy link
Member Author

@shahabhijeet conflicts are resolved.

@shahabhijeet shahabhijeet merged commit d2e42ab into Azure:psSdkJson6 Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants