Skip to content

[AppConfiguration] Fix: GetConfigurationSettings does not set the ContentType property #38917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinelski merged 5 commits into from
Sep 25, 2023
Merged

[AppConfiguration] Fix: GetConfigurationSettings does not set the ContentType property #38917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f845b51
[AppConfiguration] Added test to reproduce bug
kinelski Sep 22, 2023
2e581a4
[AppConfiguration] Implemented SettingFieldsExtensions
kinelski Sep 22, 2023
ee3c326
Updated assets.json
kinelski Sep 22, 2023
f645ac5
Forgot changelog
kinelski Sep 22, 2023
b5290c9
Addressed PR comments
kinelski Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated assets.json
  • Loading branch information
@kinelski
kinelski committed Sep 25, 2023
commit ee3c32616489b356e6c29de8350530972136355e
2 changes: 1 addition & 1 deletion sdk/appconfiguration/Azure.Data.AppConfiguration/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/appconfiguration/Azure.Data.AppConfiguration",
"Tag": "net/appconfiguration/Azure.Data.AppConfiguration_c13e90b6f4"
"Tag": "net/appconfiguration/Azure.Data.AppConfiguration_bebb69bca2"
}
2 changes: 1 addition & 1 deletion sdk/appconfiguration/Azure.Data.AppConfiguration/tests/ConfigurationLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ public async Task GetBatchSettingWithAllFields()
}

[RecordedTest]
public async Task GetBatchSettingWithAllFieldsSetIndividually()
public async Task GetBatchSettingWithAllFieldsSetExplicitly()
{
ConfigurationClient service = GetClient();
string key = GenerateKeyId("keyFields-");
Expand Down