Add result tests

sdk/core/System.ClientModel/src/Convenience/ClientRequestException.cs

@@ -7,7 +7,6 @@
 using System.IO;
 using System.Runtime.Serialization;
 using System.Text;
-using System.Threading;
 
 namespace System.ClientModel;
 

sdk/core/System.ClientModel/tests/Convenience/ClientRequestExceptionTests.cs

@@ -0,0 +1,17 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using ClientModel.Tests.Mocks;
+using NUnit.Framework;
+using System.ClientModel.Primitives;
+
+namespace System.ClientModel.Tests.Exceptions;
+
+public class ClientRequestExceptionTests
+{
+    //[Test]
+    //public void CanCreateFromResponse()
+    //{
+
+    //}
+}

sdk/core/System.ClientModel/tests/Convenience/ClientResultTests.cs

@@ -102,12 +102,58 @@ public void CanCreateDerivedOptionalResult()
         Assert.IsFalse(result.HasValue);
         Assert.AreEqual(response.Status, result.GetRawResponse().Status);
     }
+
     #endregion
 
     #region ClientResult<T>
 
+    [Test]
+    public void CannotCreateClientResultOfTFromNullResponse()
+    {
+        object value = new();
+
+        Assert.Throws<ArgumentNullException>(() => new MockClientResult<object>(value, null!));
+        Assert.Throws<ArgumentNullException>(() =>
+        {
+            OptionalClientResult<object> result = ClientResult.FromValue(value, null!);
+        });
+    }
+
+    [Test]
+    public void CannotCreateClientResultOfTFromNullValue()
+    {
+        MockPipelineResponse response = new MockPipelineResponse();
+
+        Assert.Throws<ArgumentNullException>(() => new MockClientResult<object>(null!, response));
+        Assert.Throws<ArgumentNullException>(() =>
+        {
+            OptionalClientResult<object> result = ClientResult.FromValue<object>(null!, response);
+        });
+    }
+
+    [Test]
+    public void CanCreateDerivedResult()
+    {
+        string value = "hello";
+
+        PipelineResponse response = new MockPipelineResponse(200);
+        DerivedClientResult<string> result = new(value, response);
+
+        Assert.IsTrue(result.HasValue);
+        Assert.AreEqual(value, result.Value);
+        Assert.AreEqual(response.Status, result.GetRawResponse().Status);
+    }
+
     #endregion
 
     #region Helpers
+
+    internal class DerivedClientResult<T> : ClientResult<T>
+    {
+        public DerivedClientResult(T value, PipelineResponse response) : base(value, response)
+        {
+        }
+    }
+
     #endregion
 }

sdk/core/System.ClientModel/tests/TestFramework/Mocks/MockClientResultOfT.cs

@@ -0,0 +1,14 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.ClientModel;
+using System.ClientModel.Primitives;
+
+namespace ClientModel.Tests.Mocks;
+
+public class MockClientResult<T> : ClientResult<T>
+{
+    public MockClientResult(T value, PipelineResponse response) : base(value, response)
+    {
+    }
+}