Skip to content

ClientModel Prototype: Don't keep MemoryStream buffer on PipelineResponse #41047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
annelo-msft wants to merge 9 commits into from
+43 −60
Closed

ClientModel Prototype: Don't keep MemoryStream buffer on PipelineResponse #41047

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfe293b
Don't keep MemoryStream buffer on PipelineResponse
annelo-msft Jan 6, 2024
bcaa14e
Merge remote-tracking branch 'upstream/feature/core-experiment' into …
annelo-msft Jan 9, 2024
8567315
Rework the idea
annelo-msft Jan 9, 2024
ce9a92e
comment nit
annelo-msft Jan 9, 2024
e5d58fe
fix
annelo-msft Jan 9, 2024
e0e3fc6
semi-fix
annelo-msft Jan 9, 2024
14f6cd5
Another idea that doesn't work
annelo-msft Jan 9, 2024
b5f3ef2
updates
annelo-msft Jan 10, 2024
896283f
Merge branch 'clientmodel-buffer-without-memorystream' of https://git…
annelo-msft Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@annelo-msft
annelo-msft committed Jan 9, 2024
commit e5d58fec9bc066e3257ac70d36d1f356ed47ee41
10 changes: 3 additions & 7 deletions sdk/core/System.ClientModel/src/Message/PipelineResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ public virtual Stream? ContentStream
set => _contentStream = value;
}

#region Meta-data properties set by the pipeline.

public virtual BinaryData Content
{
get
Expand Down Expand Up @@ -91,8 +89,6 @@ public virtual BinaryData Content

internal bool IsBuffered { get; private set; }

#endregion

public abstract void Dispose();

#region Response Buffering
Expand All @@ -107,7 +103,7 @@ internal void BufferContent(TimeSpan? timeout = default, CancellationTokenSource
return;
}

Stream? responseContentStream = _contentStream;
Stream? responseContentStream = ContentStream;
if (responseContentStream == null)
{
_content = s_emptyBinaryData;
Expand Down Expand Up @@ -135,8 +131,8 @@ internal async Task BufferContentAsync(TimeSpan? timeout = default, Cancellation
return;
}

Stream? responseContentStream = _contentStream;
if (responseContentStream == null || IsBuffered)
Stream? responseContentStream = ContentStream;
if (responseContentStream == null)
{
_content = s_emptyBinaryData;
return;
Expand Down