Skip to content

Update ManagementGroups SDK (2018-03-01-preview) #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 3 commits into from
May 24, 2018
Merged

Update ManagementGroups SDK (2018-03-01-preview) #4349

dsgouda merged 3 commits into from
May 24, 2018

Conversation

@rajshah11
Copy link
Contributor

@rajshah11 rajshah11 commented May 22, 2018 •
edited
Loading

Description

Rest API Spec PRs
Azure/azure-rest-api-specs#3064
Azure/azure-rest-api-specs#3115

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes May 22, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments

src/SDKs/ManagementGroups/Management.ManagementGroups/Properties/AssemblyInfo.cs Outdated
[assembly: AssemblyVersion("1.1.0.0")]
[assembly: AssemblyFileVersion("1.1.0.0")]
[assembly: AssemblyVersion("1.2.0.0")]
[assembly: AssemblyFileVersion("1.2.0.0")]
Copy link
Contributor

@dsgouda dsgouda May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only update the AssemblyFileVersion here

Copy link
Contributor Author

@rajshah11 rajshah11 May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Thanks. Will make the change.

src/SDKs/ManagementGroups/Management.ManagementGroups/Management.ManagementGroups.csproj
<PackageId>Microsoft.Azure.Management.ManagementGroups</PackageId>
<PackageTags>Microsoft Azure Management Groups;Management Groups;Groups;</PackageTags>
<PackageReleaseNotes>This is a public preview release of the Azure Management Groups SDK</PackageReleaseNotes>
<PackageReleaseNotes>This is a general availibility release of the Azure Management Groups SDK</PackageReleaseNotes>
Copy link
Contributor

@dsgouda dsgouda May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is this a stable release?

Copy link
Contributor Author

@rajshah11 rajshah11 May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We are GAing the end of this month.

Copy link
Contributor

@dsgouda dsgouda May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, you will need to remove the -preview from the package version.

Copy link
Contributor Author

@rajshah11 rajshah11 May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, if removing the preview tag is not a requirement for GAing a service we would like to keep it. Please let me know if we can keep the preview tag.

@dsgouda
Copy link
Contributor

dsgouda commented May 24, 2018

@rajshah11 if you received all the necessary information from @shahabhijeet I can approve this PR

dsgouda
dsgouda approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CIs passing

@dsgouda dsgouda merged commit d24a0b3 into Azure:psSdkJson6 May 24, 2018
This was referenced Jun 15, 2023
Merged
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rajshah11 @dsgouda