Skip to content

Conversation

@kalyanaj
Copy link
Contributor

Description

Regenerated EventGrid DataPlane SDK to include new event types.

Links to the corresponding swagger spec pull request that has been merged in the azure-rest-api-specs repository:

Azure/azure-rest-api-specs#3061
Azure/azure-rest-api-specs#3097

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code
Looks good otherwise

@kalyanaj
Copy link
Contributor Author

Thanks @dsgouda for the review! The generate script I used for this is at https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/EventGrid/DataPlane/generate.cmd. Please let me know if that's sufficient / covers what you were looking for. Thanks!

@dsgouda
Copy link
Contributor

dsgouda commented May 23, 2018

@kalyanaj yes, I understand you used the .cmd We are moving RPs towards using a ps1 script similar to one I linked to generate the code, would appreciate if you could do the same.

@kalyanaj
Copy link
Contributor Author

@dsgouda, thanks for the info. Can I take this up for the next SDK refresh (unless there's a big difference in the generated code)?

@dsgouda
Copy link
Contributor

dsgouda commented May 23, 2018

Sure, that works, please consider doing this in the next iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants