Skip to content

[ContainerApps] Remove ingore attribute and fix the recording file after containerregistray release #46635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshao25 merged 6 commits into from
Oct 16, 2024
Merged

[ContainerApps] Remove ingore attribute and fix the recording file after containerregistray release #46635

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c20f1c3
update
welovej Oct 15, 2024
9db2298
Update ContainerAppJobTests.cs
welovej Oct 16, 2024
8aa9da3
Update ContainerAppJobTests.cs
welovej Oct 16, 2024
5c3a09d
Merge remote-tracking branch 'upstream/main' into containerregistray-…
welovej Oct 16, 2024
3e1a6c7
Update Packages.Data.props
welovej Oct 16, 2024
dba414e
Merge branch 'main' into containerregistray-As-Referenced
welovej Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@
<PackageReference Update="Azure.ResourceManager.KubernetesConfiguration" Version="1.2.0-beta.1" />
<PackageReference Update="Azure.ResourceManager.ExtendedLocations" Version="1.1.0-beta.1" />
<PackageReference Update="Azure.ResourceManager.EventHubs" Version="1.0.0" />
<PackageReference Update="Azure.ResourceManager.ContainerRegistry" Version="1.1.0" />
<PackageReference Update="Azure.ResourceManager.ContainerRegistry" Version="1.3.0-beta.1" />
<PackageReference Update="Azure.Search.Documents" Version="11.2.0" />
<PackageReference Update="Azure.Security.KeyVault.Keys" Version="4.6.0" />
<PackageReference Update="Azure.Security.KeyVault.Secrets" Version="4.6.0" />
Expand Down
2 changes: 1 addition & 1 deletion sdk/containerapps/Azure.ResourceManager.AppContainers/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/containerapps/Azure.ResourceManager.AppContainers",
"Tag": "net/containerapps/Azure.ResourceManager.AppContainers_29e939e2d0"
"Tag": "net/containerapps/Azure.ResourceManager.AppContainers_d9ce2874ef"
}
1 change: 0 additions & 1 deletion sdk/containerapps/Azure.ResourceManager.AppContainers/tests/Scenario/ContainerAppJobTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public ContainerAppJobTests(bool isAsync) : base(isAsync)//, RecordedTestMode.Re

[TestCase]
[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task CreateOrUpdate()
{
ResourceGroupResource resourceGroup = await CreateResourceGroupAsync();
Expand Down
1 change: 0 additions & 1 deletion ...ntainerapps/Azure.ResourceManager.AppContainers/tests/TestCase/ContainerAppJobApiTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public ContainerAppJobApiTests(bool isAsync)

[TestCase]
[RecordedTest]
[Ignore("This test case will cause errors in the pipeline. After fixing the problem, restore this test")]
public async Task CreateOrUpdate()
{
string envName = Recording.GenerateAssetName("env");
Expand Down