feedback and get latest changes

eng/Directory.Build.Common.props

@@ -29,7 +29,7 @@
 
   <!-- Setup default project properties -->
   <PropertyGroup>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>latest</LangVersion>
     <!--
       Disable NU5105 NuGet Pack warning that the version is SemVer 2.0.
       SemVer 2.0 is supported by NuGet since 3.0.0 (July 2015) in some capacity, and fully since 3.5.0 (October 2016).

sdk/communication/Azure.Communication.CallAutomation/src/CallAutomationEventProcessor/EventBacklog.cs

@@ -52,16 +52,16 @@ internal bool TryGetAndRemoveEvent(Func<CallAutomationEventBase, bool> predicate
         {
             // Match any event that matches in the events backlog
             var matchingKvp = _eventBacklog.FirstOrDefault(kvp => predicate(kvp.Value.Item1));
+            matchingEvent = default;
 
             // Try remove the item - if successful, return it as keyValuePair
             if (matchingKvp.Key != default && _eventBacklog.TryRemove(matchingKvp.Key, out var returnedValue))
             {
-                matchingEvent = new KeyValuePair<string, CallAutomationEventBase>(matchingKvp.Key, returnedValue.Item1);
+                matchingEvent = new KeyValuePair<string, CallAutomationEventBase>(matchingEvent.Key, returnedValue.Item1);
                 return true;
             }
             else
             {
-                matchingEvent = default;
                 return false;
             }
         }

sdk/maps/Azure.Maps.Search/src/MapsSearchClient.cs

@@ -274,7 +274,9 @@ public virtual async Task<Response<Boundary>> GetPolygonAsync(GetPolygonOptions
                 }
 
                 IEnumerable<double> coordinates = null;
+#pragma warning disable CS8073 // The result of the expression is always true in .NET 8, but not this is not true in netstandard2.0
                 if (options.Coordinates != null)
+#pragma warning restore CS8073
                 {
                     coordinates = coordinates = new[]
                     {
@@ -310,7 +312,9 @@ public virtual Response<Boundary> GetPolygon(GetPolygonOptions options = null, C
                 }
 
                 IEnumerable<double> coordinates = null;
+#pragma warning disable CS8073 // The result of the expression is always true in .NET 8, but not this is not true in netstandard2.0
                 if (options.Coordinates != null)
+#pragma warning restore CS8073
                 {
                     coordinates = new[] { (double)options.Coordinates.Longitude, (double)options.Coordinates.Latitude };
                 }
@@ -344,7 +348,9 @@ public virtual async Task<Response<GeocodingResponse>> GetReverseGeocodingAsync(
                 }
 
                 IEnumerable<double> coordinatesList = null;
+#pragma warning disable CS8073 // The result of the expression is always true in .NET 8, but not this is not true in netstandard2.0
                 if (coordinates != null)
+#pragma warning restore CS8073
                 {
                     coordinatesList = new[] { coordinates.Longitude, coordinates.Latitude };
                 }
@@ -378,7 +384,9 @@ public virtual Response<GeocodingResponse> GetReverseGeocoding(GeoPosition coord
                 }
 
                 IEnumerable<double> coordinatesList = null;
+#pragma warning disable CS8073 // The result of the expression is always true in .NET 8, but not this is not true in netstandard2.0
                 if (coordinates != null)
+#pragma warning restore CS8073
                 {
                     coordinatesList = new[] { coordinates.Longitude, coordinates.Latitude };
                 }
@@ -464,7 +472,9 @@ private static ReverseGeocodingBatchRequestBody reverseGeocodingQueriesReversToG
             {
                 ReverseGeocodingBatchRequestItem item = new ReverseGeocodingBatchRequestItem();
                 item.OptionalId = query.OptionalId;
+#pragma warning disable CS8073 // The result of the expression is always true in .NET 8, but not this is not true in netstandard2.0
                 if (query.Coordinates != null)
+#pragma warning restore CS8073
                 {
                     item.Coordinates = new GeoPosition(Convert.ToDouble(query.Coordinates.Longitude), Convert.ToDouble(query.Coordinates.Latitude));
                 }

sdk/provisioning/Azure.Provisioning.CloudMachine/src/CDKLevel3/CloudMachineCommands.cs

@@ -123,7 +123,7 @@ private static void GenerateTsp(CloudMachineInfrastructure cmi)
                 name = name.Substring(1);
             string directory = Path.Combine(".", "tsp");
             string tspFile = Path.Combine(directory, $"{name}.tsp");
-            Directory.CreateDirectory(Path.GetDirectoryName(tspFile));
+            Directory.CreateDirectory(Path.GetDirectoryName(tspFile)!);
             if (File.Exists(tspFile))
                 File.Delete(tspFile);
             using FileStream stream = File.OpenWrite(tspFile);