Skip to content

Fix issue where stand-alone ManagedIdentityCredential does not consider WorkloadIdentity #46693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 2 commits into from
Oct 17, 2024
Merged

Fix issue where stand-alone ManagedIdentityCredential does not consider WorkloadIdentity #46693

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db36d75
Fix issue where stand-alone ManagedIdentityCredential does not consid…
christothes Oct 17, 2024
41344ba
fb
christothes Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fb
  • Loading branch information
@christothes
christothes committed Oct 17, 2024
commit 41344ba4c91d780acf497f638907a16d1087f1a7
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity/src/ManagedIdentityClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public ManagedIdentityClient(CredentialPipeline pipeline, ResourceIdentifier res

public ManagedIdentityClient(ManagedIdentityClientOptions options)
{
_options = options;
_options = options.Clone();
ManagedIdentityId = options.ManagedIdentityId;
Pipeline = options.Pipeline;
_isChainedCredential = options.Options?.IsChainedCredential ?? false;
Expand Down
30 changes: 30 additions & 0 deletions sdk/identity/Azure.Identity/src/ManagedIdentityClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,35 @@ internal class ManagedIdentityClientOptions
public bool ExcludeTokenExchangeManagedIdentitySource { get; set; }

public bool IsForceRefreshEnabled { get; set; }

public ManagedIdentityClientOptions Clone()
{
var cloned = new ManagedIdentityClientOptions
{
ManagedIdentityId = ManagedIdentityId,
PreserveTransport = PreserveTransport,
InitialImdsConnectionTimeout = InitialImdsConnectionTimeout,
Pipeline = Pipeline,
ExcludeTokenExchangeManagedIdentitySource = ExcludeTokenExchangeManagedIdentitySource,
IsForceRefreshEnabled = IsForceRefreshEnabled,
};

if (Options != null)
{
if (Options is DefaultAzureCredentialOptions dac)
{
cloned.Options = dac.Clone<DefaultAzureCredentialOptions>();
}
else if (Options is ManagedIdentityCredentialOptions mic)
{
cloned.Options = mic.Clone<ManagedIdentityCredentialOptions>();
}
else
{
cloned.Options = Options.Clone<TokenCredentialOptions>();
}
}
return cloned;
}
}
}