Skip to content

Sync eng/common directory with azure-sdk-tools for PR 9181 #46695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 3 commits into from
Oct 18, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 9181 #46695

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d991b32
add the ability to pass a servicedirectoryFilter. This will allow us …
scbedd Oct 15, 2024
83c11b9
hardcode this logic to only activate the new pr logic for service dir…
scbedd Oct 17, 2024
98ce04c
update the comment
scbedd Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion eng/common/pipelines/templates/steps/save-package-properties.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ parameters:
default: eng/common/scripts

steps:
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
# There will be transitory period for every language repo where the <language> - pullrequest build definition will run
# alongside the <language> - <service> - ci definitions. These pullrequest build definitions will have the ServiceDirectory parameter
# set to 'auto', which will allow the expanding and contracting based on PR Diff.

# The other public CI builds will pass a real service directory, which will not activate the PR diff logic and as such will operate
# as before this change.
- ${{ if and(eq(variables['Build.Reason'], 'PullRequest'), eq(parameters.ServiceDirectory, 'auto')) }}:
- task: Powershell@2
displayName: Generate PR Diff
inputs:
Expand Down