Skip to content

Sync eng/common directory with azure-sdk-tools for PR 9333 #47008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azure-sdk merged 5 commits into from
Nov 7, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 9333 #47008

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9992a03
Retry container deletion
benbp Nov 5, 2024
afdc9dc
Do not try to purge keyvaults with purge protection
benbp Nov 5, 2024
fb2ce9c
Delete all blobs when container has immutability
benbp Nov 5, 2024
4423bc2
Skip missing blob container properties
benbp Nov 5, 2024
c738500
Fix null container
benbp Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not try to purge keyvaults with purge protection
  • Loading branch information
@benbp @azure-sdk
benbp authored and azure-sdk committed Nov 6, 2024
commit afdc9dc7b41f0a05c903dbf222b7cd0be15bb124
4 changes: 2 additions & 2 deletions eng/common/scripts/Helpers/Resource-Helpers.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ filter Remove-PurgeableResources {
switch ($r.AzsdkResourceType) {
'Key Vault' {
if ($r.EnablePurgeProtection) {
# We will try anyway but will ignore errors.
Write-Warning "Key Vault '$($r.VaultName)' has purge protection enabled and may not be purged until $($r.ScheduledPurgeDate)"
continue
}

# Use `-AsJob` to start a lightweight, cancellable job and pass to `Wait-PurgeableResoruceJob` for consistent behavior.
Expand All @@ -134,8 +134,8 @@ filter Remove-PurgeableResources {

'Managed HSM' {
if ($r.EnablePurgeProtection) {
# We will try anyway but will ignore errors.
Write-Warning "Managed HSM '$($r.Name)' has purge protection enabled and may not be purged until $($r.ScheduledPurgeDate)"
continue
}

# Use `GetNewClosure()` on the `-Action` ScriptBlock to make sure variables are captured.
Expand Down