Skip to content

[Storage] [DataMovement] Using Entra ID with Share File will set the ShareFileIntent for FromDirectory and FromFile #47010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amnguye merged 2 commits into from
Nov 7, 2024
Merged

[Storage] [DataMovement] Using Entra ID with Share File will set the ShareFileIntent for FromDirectory and FromFile #47010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce9bae
On default using Entra ID with Share File will set the ShareFileInten…
amnguye Nov 7, 2024
a6543ea
Extra whitespace
amnguye Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Extra whitespace
  • Loading branch information
@amnguye
amnguye committed Nov 7, 2024
commit a6543eaafe0cbcc695dfbcab249207668b7f84c5
2 changes: 1 addition & 1 deletion sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/ShareFilesStorageResourceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ public StorageResource FromDirectory(Uri directoryUri, ShareFileStorageResourceO
CredentialType.Token => new ShareDirectoryClient(
directoryUri,
_getTokenCredential(directoryUri, false),
new ShareClientOptions { ShareTokenIntent = ShareTokenIntent.Backup }),
new ShareClientOptions { ShareTokenIntent = ShareTokenIntent.Backup }),
CredentialType.Sas => new ShareDirectoryClient(directoryUri, _getAzureSasCredential(directoryUri, false)),
_ => throw BadCredentialTypeException(_credentialType),
};
Expand Down