Skip to content

Conversation

@ilidemi
Copy link

@ilidemi ilidemi commented Sep 4, 2018

Microsoft.ResourceGraph is a new resource provider that allows customers to explore their Azure resources at scale using a powerful query language (KQL). We are launching in Public Preview at Ignite and aiming to release CLI/PowerShell tools by then.

More info here: https://aka.ms/resource-graph/intro

Swagger spec PRs: #3716 and #3796
Autorest config PR: #3795


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great apart from a minor comment. Thanks for addressing all the warnings

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a comment

@dsgouda
Copy link
Contributor

dsgouda commented Sep 5, 2018

@demyanenko squash commits into a single commit and we are good to merge

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilidemi
Copy link
Author

ilidemi commented Sep 5, 2018

@dsgouda Squashed and pushed.

@dsgouda dsgouda merged commit 2ea6967 into Azure:psSdkJson6 Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants