Updating customconfig to string #4740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q3blend
force-pushed
the
customsearch/customconfig-to-string
branch
2 times, most recently
from
6da5632 to
8c586f1
Compare
dsgouda
suggested changes
Sep 6, 2018
...ngCustomSearch/BingCustomSearch/Microsoft.Azure.CognitiveServices.Search.CustomSearch.csproj
Outdated
Show resolved
Hide resolved
.../dataPlane/Search/BingCustomSearch/BingCustomSearch/Generated/CustomSearch/CustomInstance.cs
Outdated
Show resolved
Hide resolved
...ices/dataPlane/Search/BingCustomImageSearch/BingCustomImageSearch/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
dsgouda
suggested changes
Sep 6, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
It looks like the REST spec is still not merged. We cannot merge this
src/SDKs/_metadata/cognitiveservices_data-plane_CustomImageSearch.txt
Outdated
Show resolved
Hide resolved
q3blend
force-pushed
the
customsearch/customconfig-to-string
branch
2 times, most recently
from
64f4dd7 to
8bd84ce
Compare
dsgouda
suggested changes
Sep 13, 2018
src/SDKs/_metadata/cognitiveservices_data-plane_CustomSearch.txt
Outdated
Show resolved
Hide resolved
src/SDKs/_metadata/cognitiveservices_data-plane_CustomImageSearch.txt
Outdated
Show resolved
Hide resolved
dsgouda
suggested changes
Sep 25, 2018
...ices/dataPlane/Search/BingCustomImageSearch/BingCustomImageSearch/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
...nitiveServices/dataPlane/Search/BingCustomSearch/BingCustomSearch/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
q3blend
force-pushed
the
customsearch/customconfig-to-string
branch
from
9fb1ac1 to
58b82b3
Compare
dsgouda
suggested changes
Sep 26, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good, please address the 2 comments and squash your commits into a single commit, should be good to merge once addressed
...ices/dataPlane/Search/BingCustomImageSearch/BingCustomImageSearch/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Same as above for AssemblyVersion
q3blend
force-pushed
the
customsearch/customconfig-to-string
branch
from
5972ab8 to
395bfdd
Compare
q3blend
force-pushed
the
customsearch/customconfig-to-string
branch
from
395bfdd to
bf5cd68
Compare
Contributor
Author
|
@dsgouda can you merge this? I believe all the comments were addressed |
dsgouda
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.spec: Azure/azure-rest-api-specs#3799