Skip to content

Replace ResourceDataProvdier with ResoruceVisitor #48362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live1206 merged 11 commits into from
Feb 24, 2025
Merged

Replace ResourceDataProvdier with ResoruceVisitor #48362

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
78039cb
Replace ResourceDataProvdier with ResoruceVisitor
live1206 Feb 20, 2025
3210a5e
update MGC and fix renaming
live1206 Feb 20, 2025
dfe069e
update
live1206 Feb 20, 2025
3d05fd6
update lock file
live1206 Feb 20, 2025
216654c
update
live1206 Feb 20, 2025
86050c2
update test
live1206 Feb 20, 2025
b8f8a20
Address comments
live1206 Feb 21, 2025
c301d2e
remvoe unnecessary override
live1206 Feb 21, 2025
355bf08
update tests
live1206 Feb 21, 2025
819d7ba
update
live1206 Feb 21, 2025
84afbf5
update visitor methods
live1206 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@live1206
live1206 committed Feb 20, 2025
commit dfe069eaefab48e6fa0d64978e2f7de9db4baa25
2 changes: 0 additions & 2 deletions eng/packages/http-client-csharp/generator/Azure.Generator/src/ResourceVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ internal class ResourceVisitor : ScmLibraryVisitor
{
protected override ModelProvider? Visit(InputModelType model, ModelProvider? type)
{
base.Visit(model, type);
if (type is not null)
{
TransformResource(type);
Expand All @@ -22,7 +21,6 @@ internal class ResourceVisitor : ScmLibraryVisitor

protected override TypeProvider? Visit(TypeProvider type)
{
base.Visit(type);
TransformResource(type);
return type;
}
Expand Down
10 changes: 4 additions & 6 deletions eng/packages/http-client-csharp/generator/Azure.Generator/src/RestClientVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,17 @@ internal class RestClientVisitor : ScmLibraryVisitor
/// <inheritdoc/>
protected override TypeProvider? Visit(TypeProvider type)
{
var result = base.Visit(type);

if (result is ClientProvider)
if (type is not null && type is ClientProvider)
{
result.DeclarationModifiers = TransfromPublicModifiersToInternal(result);
result.RelativeFilePath = TransformRelativeFilePathForClient(result);
type.DeclarationModifiers = TransfromPublicModifiersToInternal(type);
type.RelativeFilePath = TransformRelativeFilePathForClient(type);
}
// TODO: uncomment this once resources are generated
//if (type is RestClientProvider)
//{
// type.Update(modifiers: TransfromPublicModifiersToInternal(type), relativeFilePath: TransformRelativeFilePathForRestClient(type));
//}
return result;
return type;
}

private static string TransformRelativeFilePathForClient(TypeProvider type)
Expand Down
Loading