-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Bump the version to 1.24.0-preview #5043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@NMijat1024 Please resolve merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the change being introduced in this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the reason for this PR on the top of the description
|
Per our guidelines, please squash commits into a single commit and update the PR. Looks good for the most part but curious if this is a version bump without any changes |
|
Resolved @dsgouda |
|
We should probably be using feature branches to avoid such confusion. I also see that there is this PR open, should it be merged before or after this PR. |
|
I guess it is okay to merge this PR first, because nuget package version 1.23.0-preview is already published. |
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge on CIs passing
|
@dsgouda Just wait to squash commits. :) |
7a01b12 to
72198ec
Compare
|
@NMijat1024 please resolve conflicts and update the PR |
4a0bd77 to
72198ec
Compare
72198ec to
4a34d99
Compare
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Because #5008 was merged after publishing the 1.23.0-preview, I need to change the version.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.