[AutoPR Azure.ResourceManager.StorageDiscovery]-generated-from-SDK Generation - .NET-5137373 #51458
Conversation
…overy.Management/tspconfig.yaml', API Version: 2025-06-01-preview, SDK Release Type: beta, and CommitSHA: 'b03475447ff6b3bcccfd25e99609b63bb2877b09' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
github-actions
bot
added
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
shanefujs
requested review from
ArcturusZhang,
ArthurMa1978,
amnguye,
jalauzon-msft,
jaschrep-msft and
seanmcc-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Azure Resource Manager SDK for StorageDiscovery as a beta preview library. The pull request adds the initial implementation generated from the API specification for Azure Storage Discovery Management service (API version 2025-06-01-preview).
- Introduces the Azure.ResourceManager.StorageDiscovery package with complete SDK structure
- Provides resource management capabilities for StorageDiscovery workspaces
- Establishes testing framework and CI/CD pipeline configuration
Reviewed Changes
Copilot reviewed 15 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storagediscovery/ci.yml | CI/CD pipeline configuration for building and testing the SDK |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/tsp-location.yaml | TypeSpec configuration linking to Azure REST API specs repository |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/tests/*.cs | Test framework classes and project configuration |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/src/*.cs | Main SDK project files and assembly metadata |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/api/*.cs | Generated API surface definitions for .NET Standard 2.0 and .NET 8.0 |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/*.md | Documentation and changelog for the new SDK |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/*.sln | Visual Studio solution file |
| sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery/assets.json | Test assets configuration |
|
|
||
| [assembly: InternalsVisibleTo("Azure.ResourceManager.StorageDiscovery.Tests, PublicKey = 0024000004800000940000000602000000240000525341310004000001000100d15ddcb29688295338af4b7686603fe614abd555e09efba8fb88ee09e1f7b1ccaeed2e8f823fa9eef3fdd60217fc012ea67d2479751a0b8c087a4185541b851bd8b16f8d91b840e51b1cb0ba6fe647997e57429265e85ef62d565db50a69ae1647d54d7bd855e4db3d8a91510e5bcbd0edfbbecaa20a7bd9ae74593daa7b11b4")] | ||
|
|
||
| // Replace Microsoft.Test with the correct resource provider namepace for your service and uncomment. |
There was a problem hiding this comment.
The word 'namepace' should be spelled 'namespace'.
| // Replace Microsoft.Test with the correct resource provider namepace for your service and uncomment. | |
| // Replace Microsoft.Test with the correct resource provider namespace for your service and uncomment. |
| @@ -0,0 +1,80 @@ | |||
| # Microsoft Azure StorageDiscovery management client library for .NET | |||
|
|
|||
| **[Describe the service briefly first.]** | |||
There was a problem hiding this comment.
The placeholder text for service description should be replaced with actual information about the Storage Discovery service.
| **[Describe the service briefly first.]** | |
| **Microsoft Azure Storage Discovery** is a service designed to help users efficiently manage and discover storage resources across their Azure subscriptions. It provides tools for identifying, organizing, and monitoring storage accounts, enabling seamless integration with other Azure services and ensuring optimal resource utilization. |
There was a problem hiding this comment.
Please add some description for your RP here.
|
@ArcturusZhang @ArthurMa1978 this PR should be ready for review. |
|
https://github.com/Azure/azure-sdk-pr/issues/2257 |
There was a problem hiding this comment.
Not quite sure why we still have this file, but please remove this file (and its directory as well)
| public static Azure.ResourceManager.StorageDiscovery.Models.StorageDiscoveryWorkspaceProperties StorageDiscoveryWorkspaceProperties(Azure.ResourceManager.StorageDiscovery.Models.StorageDiscoverySku? sku = default(Azure.ResourceManager.StorageDiscovery.Models.StorageDiscoverySku?), string description = null, System.Collections.Generic.IEnumerable<Azure.Core.ResourceIdentifier> workspaceRoots = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.StorageDiscovery.Models.StorageDiscoveryScope> scopes = null, Azure.ResourceManager.StorageDiscovery.Models.ResourceProvisioningState? provisioningState = default(Azure.ResourceManager.StorageDiscovery.Models.ResourceProvisioningState?)) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct ResourceProvisioningState : System.IEquatable<Azure.ResourceManager.StorageDiscovery.Models.ResourceProvisioningState> |
There was a problem hiding this comment.
We should rename this type to StorageDiscoveryProvisioningState.
ArcturusZhang
left a comment
ArcturusZhang
left a comment
There was a problem hiding this comment.
In general this PR looks good!
There is one renaming comment - please open a PR in azure-rest-api-specs repo and add @@clientName(TheType, "The new name", "csharp"); statements in client.tsp file.
Before the spec PR merges, please validate your changes could change the name by running the following command in sdk/storagediscovery/Azure.ResourceManager.StorageDiscovery directory:
dotnet build /t:GenerateCode /p:LocalSpecRepo="/absolute/path/of/your/spec" && ../../../eng/scripts/Export-API.ps1 storagediscovery
Once the spec PR merges, we also need to update the commit id in tsp-location.yaml file and regenerate the code.
|
superseded by #51594 |
3 participants
Configurations: 'specification/storagediscovery/Microsoft.StorageDiscovery.Management/tspconfig.yaml', API Version: 2025-06-01-preview, SDK Release Type: beta, and CommitSHA: 'b03475447ff6b3bcccfd25e99609b63bb2877b09' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'