Draft: Perf Counter Implementation #52679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <returns>The new value after incrementing.</returns> | ||
| public long IncrementRequestCount() | ||
| { | ||
| return Interlocked.Increment(ref _totalRequestCount); |
Contributor
There was a problem hiding this comment.
Request rate should be derived from http.server.request.duration metrics by taking the histogram count and dividing by 60 (the aggregation window) to get requests per second.
| /// <returns>The new value after incrementing.</returns> | ||
| public long IncrementExceptionCount() | ||
| { | ||
| return Interlocked.Increment(ref _totalExceptionCount); |
Contributor
There was a problem hiding this comment.
Exception rate should be derived from process.runtime.dotnet.exceptions.count metrics from the System.Runtime meter by calculating count / 60 to get exceptions per second.
| description: "Request rate gauge (req/sec)"); | ||
|
|
||
| _processCpuGauge = _perfCounterMeter.CreateObservableGauge( | ||
| PerfCounterConstants.ProcessCpuInstrumentName, |
Contributor
There was a problem hiding this comment.
| { | ||
| _meterProvider = Sdk.CreateMeterProviderBuilder() | ||
| .AddMeter(StandardMetricConstants.StandardMetricMeterName) | ||
| .AddMeter(PerfCounterConstants.PerfCounterMeterName) |
Contributor
There was a problem hiding this comment.
This should be wired with customer's meter provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the current state of perf counters implementation. Implements five performance counters, tests not implemented yet.