Skip to content

[AzureMonitorExporter] Add Performance Counter Support #52705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajkumar-rangaraj merged 11 commits into from
Oct 3, 2025
Merged

[AzureMonitorExporter] Add Performance Counter Support #52705

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9389443
Added Performance metrics.
rajkumar-rangaraj Sep 18, 2025
c75e04e
Update tests
rajkumar-rangaraj Sep 18, 2025
05422d7
copilot feedback
rajkumar-rangaraj Sep 18, 2025
13a3111
resolve conflicts
rajkumar-rangaraj Oct 2, 2025
86d1d28
request and exception rate fix
rajkumar-rangaraj Oct 2, 2025
4c658ea
Fix event id numbers
rajkumar-rangaraj Oct 2, 2025
8ade55d
remove runtime metrics
rajkumar-rangaraj Oct 2, 2025
1c91a94
test update
rajkumar-rangaraj Oct 2, 2025
54614db
test fix
rajkumar-rangaraj Oct 3, 2025
0b57aff
Revert test change as rate is unpreditable due to CI calculated excep…
rajkumar-rangaraj Oct 3, 2025
5f6255e
Resolve conflicts
rajkumar-rangaraj Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
copilot feedback
  • Loading branch information
@rajkumar-rangaraj
rajkumar-rangaraj committed Sep 18, 2025
commit 05422d7592625753bc69d9aedfff19ed79b4719c
5 changes: 1 addition & 4 deletions .../Azure.Monitor.OpenTelemetry.Exporter/src/Internals/StandardMetricsExtractionProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ internal StandardMetricsExtractionProcessor(AzureMonitorMetricExporter metricExp

_perfCounterMeter = new Meter(PerfCounterConstants.PerfCounterMeterName);
_requestRate = _perfCounterMeter.CreateCounter<long>(PerfCounterConstants.RequestRateInstrumentationName);
_processPrivateBytesGauge = _standardMetricMeter.CreateObservableGauge<long>(PerfCounterConstants.ProcessPrivateBytesInstrumentationName, () => GetProcessPrivateBytes());
_processPrivateBytesGauge = _perfCounterMeter.CreateObservableGauge<long>(PerfCounterConstants.ProcessPrivateBytesInstrumentationName, () => GetProcessPrivateBytes());
_processCpuGauge = _perfCounterMeter.CreateObservableGauge<double>(PerfCounterConstants.ProcessCpuInstrumentationName, () => GetProcessCPU());
_processCpuNormalizedGauge = _perfCounterMeter.CreateObservableGauge<double>(PerfCounterConstants.ProcessCpuNormalizedInstrumentationName, () => GetProcessCPUNormalized());
InitializeCpuBaseline();
Expand Down Expand Up @@ -247,7 +247,6 @@ private bool TryCalculateCPUCounter(out double rawValue, out double normalizedVa

if (previousCollectedTime == DateTimeOffset.MinValue)
{
Debug.WriteLine($"{nameof(TryCalculateCPUCounter)} DateTimeOffset.MinValue");
rawValue = default;
normalizedValue = default;
return false;
Expand All @@ -260,7 +259,6 @@ private bool TryCalculateCPUCounter(out double rawValue, out double normalizedVa
previousCollectedTime: previousCollectedTime.Ticks,
recentCollectedTime: recentCollectedTime.Ticks);

Debug.WriteLine($"{nameof(TryCalculateCPUCounter)} period less than or equal to zero");
rawValue = default;
normalizedValue = default;
return false;
Expand All @@ -273,7 +271,6 @@ private bool TryCalculateCPUCounter(out double rawValue, out double normalizedVa
previousCollectedValue: previousCollectedValue,
recentCollectedValue: recentCollectedValue);

Debug.WriteLine($"{nameof(TryCalculateCPUCounter)} diff less than zero");
rawValue = default;
normalizedValue = default;
return false;
Expand Down
2 changes: 1 addition & 1 deletion ...elemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/StandardMetricTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ public void ValidatePerfCounterMetrics()
// Helper local function to find metric by mapped name.
MetricsData? FindMetric(string expectedName) => metricTelemetryItems
.Select(ti => (MetricsData)ti.Data.BaseData)
.FirstOrDefault(md => md.Metrics[0].Name == expectedName);
.FirstOrDefault(md => md.Metrics.Count > 0 && md.Metrics[0].Name == expectedName);

var requestRate = FindMetric(PerfCounterConstants.RequestRateMetricIdValue);
Assert.NotNull(requestRate);
Expand Down