Azure Search: Regenerate management SDK to add service identity #5332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@natinimni Can you please provide a link to the Swagger spec PR on which this change is based? |
Contributor
Author
|
Related swagger PR: Azure/azure-rest-api-specs#5319 |
brjohnstmsft
suggested changes
Mar 14, 2019
Member
brjohnstmsft
left a comment
brjohnstmsft
left a comment
There was a problem hiding this comment.
The changes to the Resource and SearchService constructors, while not breaking at compile-time, are breaking changes in terms of binary compatibility, so please bump the major version number of the SDK.
src/SDKs/Search/Management/Search.Management.Tests/Tests/SearchServiceTests.cs
Outdated
Show resolved
Hide resolved
brjohnstmsft
approved these changes
Mar 14, 2019
Contributor
|
@brjohnstmsft is this ready to merge? |
Member
|
@dsgouda Yes, please merge it. |
shmed
pushed a commit
to shmed/azure-sdk-for-net
that referenced
this pull request
Apr 5, 2019
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
shmed
pushed a commit
to shmed/azure-sdk-for-net
that referenced
this pull request
Apr 6, 2019
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
…e#5332) * Azure Search: Regenerate management SDK to add service identity * Azure search MGMTSDK: Updating tests recordings * Addressing PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating management SDK to get latest MSI related changed from the spec