Skip to content

[Storage] [WebJobs] LogScan new blobs between the start of polling and the LMT of the last LogScan #53767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amnguye wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[Storage] [WebJobs] LogScan new blobs between the start of polling and the LMT of the last LogScan #53767

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d1a86fb
LogScan new blobs between the start of polling and the LMT of the las…
amnguye Nov 7, 2025
a098b2c
Update changelog; Update scanner to check if cont token is null befor…
amnguye Nov 18, 2025
540ec53
Completed test for polling blob with different LMT
amnguye Dec 3, 2025
aaed34c
Merge branch 'main' into fix/storage/logscan-earlyblobs
amnguye Dec 3, 2025
c68a7b4
Updated changelog to hopefully better phrasing
amnguye Dec 3, 2025
e122815
Copilot comments + changed DateTime usage to DateTimeOffset
amnguye Dec 4, 2025
20e3c52
Add docs for TestAsyncPageableWithContinuationToken
amnguye Dec 4, 2025
c930734
Undo changes to sln
amnguye Dec 4, 2025
61d855e
Update to tests from DateTime to DateTimeOffset
amnguye Dec 5, 2025
3ed42ec
Merge branch 'main' into fix/storage/logscan-earlyblobs
amnguye Dec 5, 2025
b294bb7
Fix test UpdateLatestScan_Inserts
amnguye Dec 5, 2025
62ddef9
Merge branch 'main' into fix/storage/logscan-earlyblobs
amnguye Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changelog; Update scanner to check if cont token is null befor… 
…e setting current lmt time
  • Loading branch information
@amnguye
amnguye committed Nov 18, 2025
commit a098b2c8a225906c08987005f11ce1fa68b4bf0b
1 change: 1 addition & 0 deletions sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Breaking Changes

### Bugs Fixed
- Fixed a bug where polling for new blobs fails to detect newly created blobs when the List Blobs/Get Blobs operation requires multiple requests. If a blob is added or modified after LogScan begins, and is listed during the later portion of the listing, any blobs changed between the listing start time and the last modified timestamp of blobs found later will not be flagged as new in the subsequent LogScan.
Copy link
Member Author

@amnguye amnguye Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not my favorite changelog message, any rewording suggestions is welcomed here.

Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The bug description is verbose and could be simplified for better readability. Consider rephrasing to: "Fixed a bug where polling for new blobs fails to detect blobs modified between the start of a multi-page blob listing and the last modified timestamp of blobs found in later pages."

Suggested change
- Fixed a bug where polling for new blobs fails to detect newly created blobs when the List Blobs/Get Blobs operation requires multiple requests. If a blob is added or modified after LogScan begins, and is listed during the later portion of the listing, any blobs changed between the listing start time and the last modified timestamp of blobs found later will not be flagged as new in the subsequent LogScan.
- Fixed a bug where polling for new blobs fails to detect blobs modified between the start of a multi-page blob listing and the last modified timestamp of blobs found in later pages.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@amnguye amnguye Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fix details best how this issue is exposed. But if others would rather see it shortened to this, I can do that.


### Other Changes

Expand Down
2 changes: 1 addition & 1 deletion ...re.WebJobs.Extensions.Storage.Blobs/src/Listeners/ScanBlobScanLogHybridPollingStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ public async Task<IEnumerable<BlobBaseClient>> PollNewBlobsAsync(
DateTime lastModifiedTimestamp = properties.LastModified.Value.UtcDateTime;

if (lastModifiedTimestamp > containerScanInfo.CurrentSweepCycleLatestModified &&
lastModifiedTimestamp <= containerScanInfo.PollingStartTime)
(continuationToken == null || lastModifiedTimestamp <= containerScanInfo.PollingStartTime))
{
containerScanInfo.CurrentSweepCycleLatestModified = lastModifiedTimestamp;
}
Expand Down