-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add more service owners under confidentialledger sdk #54281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more service owners under confidentialledger sdk #54281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds 6 new service owners to the Confidential Ledger SDK team, representing contributors who have worked on the codebase in the past year.
- Added 6 new GitHub users as code owners and service owners for the confidentialledger SDK
- Updated both PRLabel and ServiceOwners sections consistently
jsquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few accounts that need adjustments for this to merge:
- prathod09 is missing a public membership to the
Microsoftorg - ryazhang-microsoft is missing a public membership to the
Microsoftorg - msftsettiy is missing a public membership to the
Microsoftorg - weirenlai is missing a public membership to the
Microsoftorg
Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your accounts by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
|
@jsquire Accounts updated, it seems that codeowners linter was only checking for Azure members but not Microsoft org membership IMO. |
Added users from the team who contributed to the source in the past year
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.