Skip to content

Update azure-typespec/http-client-csharp-mgmt version to prerelease 1.0.0-alpha.20260202.3#55443

Open
azure-sdk wants to merge 5 commits intoAzure:mainfrom
azure-sdk:validate-typespec-20260202.3-azure-typespec/http-client-csharp-mgmt
Open

Update azure-typespec/http-client-csharp-mgmt version to prerelease 1.0.0-alpha.20260202.3#55443
azure-sdk wants to merge 5 commits intoAzure:mainfrom
azure-sdk:validate-typespec-20260202.3-azure-typespec/http-client-csharp-mgmt

Conversation

@azure-sdk
Copy link
Collaborator

Generated by branded - http-client-csharp-mgmt build 20260202.3
Triggered from branch: main

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @azure-typespec/http-client-csharp-mgmt generator dependency to 1.0.0-alpha.20260202.3 and refreshes generated .NET SDK sources produced by that generator build.

Changes:

  • Bump the mgmt TypeSpec C# generator package version in eng/ (package + lockfile).
  • Regenerate multiple ARM SDK Generated/ files, primarily updating parameter names for request bodies.
  • Regenerate HybridConnectivity endpoint resource code, including removal of credential-related methods.

Reviewed changes

Copilot reviewed 1 out of 37 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/storageactions/Azure.ResourceManager.StorageActions/src/Generated/StorageTaskCollection.cs Renames request-body parameter from data to storageTaskData in create/update methods.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedServiceCollection.cs Renames request-body parameter to a type-specific name.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedNodeTypeCollection.cs Renames request-body parameter to a type-specific name.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedClusterCollection.cs Renames request-body parameter to a type-specific name.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedApplicationTypeVersionCollection.cs Renames request-body parameter to a type-specific name.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedApplicationTypeCollection.cs Renames request-body parameter to a type-specific name.
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Generated/ServiceFabricManagedApplicationCollection.cs Renames request-body parameter to a type-specific name.
sdk/quota/Azure.ResourceManager.Quota/src/Generated/GroupQuotaSubscriptionCollection.cs Alters CreateOrUpdate APIs for group quota subscriptions (currently introduces an invalid default subscription ID usage).
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServersPrivateEndpointConnectionResource.cs Renames update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServersPrivateEndpointConnectionCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerFirewallRuleResource.cs Renames update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerFirewallRuleCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerDatabaseResource.cs Renames update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerDatabaseCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerConfigurationResource.cs Renames update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerConfigurationCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerBackupV2Resource.cs Renames optional update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerBackupV2Collection.cs Renames optional create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerAadAdministratorResource.cs Renames update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/MySqlFlexibleServerAadAdministratorCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/mysql/Azure.ResourceManager.MySql/src/Generated/AdvancedThreatProtectionCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/keyvault/Azure.ResourceManager.KeyVault/src/Generated/ManagedHsmResource.cs Renames update request-body parameter to managedHsmData.
sdk/keyvault/Azure.ResourceManager.KeyVault/src/Generated/ManagedHsmCollection.cs Renames create/update request-body parameter to managedHsmData.
sdk/hybridconnectivity/Azure.ResourceManager.HybridConnectivity/src/Generated/HybridConnectivityEndpointResource.cs Removes credential-related instance methods from the generated endpoint resource.
sdk/healthbot/Azure.ResourceManager.HealthBot/src/Generated/HealthBotCollection.cs Renames create/update request-body parameter to healthBotData.
sdk/hardwaresecuritymodules/Azure.ResourceManager.HardwareSecurityModules/src/Generated/DedicatedHsmCollection.cs Renames create/update request-body parameter to dedicatedHsmData.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanVolumeGroupCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanVolumeCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanSnapshotResource.cs Renames update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanSnapshotCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanPrivateEndpointConnectionResource.cs Renames update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanPrivateEndpointConnectionCollection.cs Renames create/update request-body parameter to a type-specific name.
sdk/elasticsan/Azure.ResourceManager.ElasticSan/src/Generated/ElasticSanCollection.cs Renames create/update request-body parameter to elasticSanData.
sdk/cognitivelanguage/Azure.AI.Language.Text.Authoring/src/Generated/Internal/TypeFormatters.cs Adds using System.Xml; and uses XmlConvert without full qualification.
eng/azure-typespec-http-client-csharp-mgmt-emitter-package.json Bumps @azure-typespec/http-client-csharp-mgmt to 1.0.0-alpha.20260202.3.
eng/azure-typespec-http-client-csharp-mgmt-emitter-package-lock.json Updates lockfile for the bumped mgmt generator and related transitive dependencies.
Files not reviewed (1)
  • eng/azure-typespec-http-client-csharp-mgmt-emitter-package-lock.json: Language not supported

/// <param name="subscriptionId"> The ID of the target subscription. The value must be an UUID. </param>
/// <param name="cancellationToken"> The cancellation token to use. </param>
public virtual async Task<ArmOperation<GroupQuotaSubscriptionResource>> CreateOrUpdateAsync(WaitUntil waitUntil, Guid subscriptionId, CancellationToken cancellationToken = default)
public virtual async Task<ArmOperation<GroupQuotaSubscriptionResource>> CreateOrUpdateAsync(WaitUntil waitUntil, CancellationToken cancellationToken = default)
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateOrUpdateAsync no longer accepts the subscriptionId required by the REST path (.../subscriptions/{subscriptionId}), which makes it impossible to target a specific subscription and will also break existing overloads in the partial Custom/GroupQuotaSubscriptionCollection.cs that call the Guid-based method. Restore the Guid subscriptionId parameter (and related docs/argument validation).

Copilot uses AI. Check for mistakes.
CancellationToken = cancellationToken
};
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, subscriptionId, context);
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, default, context);
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call passes default for subscriptionId into CreateCreateOrUpdateRequest(...), resulting in an all-zero GUID in the request URI. Use the actual subscription id passed into the public API (and validate it) instead of default.

Suggested change
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, default, context);
string subscriptionId = Id.SubscriptionId;
if (string.IsNullOrEmpty(subscriptionId) || !Guid.TryParse(subscriptionId, out Guid subscriptionGuid))
{
throw new InvalidOperationException("The resource identifier does not contain a valid subscription ID.");
}
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, subscriptionGuid, context);

Copilot uses AI. Check for mistakes.
/// <param name="subscriptionId"> The ID of the target subscription. The value must be an UUID. </param>
/// <param name="cancellationToken"> The cancellation token to use. </param>
public virtual ArmOperation<GroupQuotaSubscriptionResource> CreateOrUpdate(WaitUntil waitUntil, Guid subscriptionId, CancellationToken cancellationToken = default)
public virtual ArmOperation<GroupQuotaSubscriptionResource> CreateOrUpdate(WaitUntil waitUntil, CancellationToken cancellationToken = default)
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateOrUpdate no longer accepts the subscriptionId required by the REST path (.../subscriptions/{subscriptionId}), which makes it impossible to target a specific subscription and will also break existing overloads in the partial Custom/GroupQuotaSubscriptionCollection.cs that call the Guid-based method. Restore the Guid subscriptionId parameter (and related docs/argument validation).

Copilot uses AI. Check for mistakes.
CancellationToken = cancellationToken
};
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, subscriptionId, context);
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, default, context);
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call passes default for subscriptionId into CreateCreateOrUpdateRequest(...), resulting in an all-zero GUID in the request URI. Use the actual subscription id passed into the public API (and validate it) instead of default.

Suggested change
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, default, context);
if (string.IsNullOrEmpty(Id.SubscriptionId) || !Guid.TryParse(Id.SubscriptionId, out Guid subscriptionGuid))
{
throw new ArgumentException("The resource identifier does not contain a valid subscription ID.", nameof(Id));
}
HttpMessage message = _groupQuotaSubscriptionIdsRestClient.CreateCreateOrUpdateRequest(Id.Parent.Name, Id.Name, subscriptionGuid, context);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cognitive - Language Hardware Security Modules HybridConnectivity Mgmt This issue is related to a management package. Quota Quota Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants