Add generated code and SDK API tests for Personalizer v1.0 preview #5944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwaijam
changed the title
yangyuan
approved these changes
Apr 24, 2019
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/Personalizer.csproj
Outdated
Show resolved
Hide resolved
dsgouda
suggested changes
Apr 25, 2019
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/Personalizer.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/generate.ps1
Outdated
Show resolved
Hide resolved
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/generate.ps1
Outdated
Show resolved
Hide resolved
Contributor
|
Created for Azure/azure-rest-api-specs#5743 |
dwaijam
changed the title
dsgouda
suggested changes
Apr 29, 2019
src/SDKs/CognitiveServices/dataPlane/Personalizer/Personalizer/Personalizer.csproj
Outdated
Show resolved
Hide resolved
dsgouda
reviewed
Apr 29, 2019
| <Description>Microsoft.Azure.CognitiveServices.Personalizer.Tests Class Library</Description> | ||
| <AssemblyName>Microsoft.Azure.CognitiveServices.Personalizer.Tests</AssemblyName> | ||
| <Version>1.0.0</Version> | ||
| <Version>0.8.0-preview</Version> |
Contributor
There was a problem hiding this comment.
Test project version must be set to 1.0.0 and never modified. Not blocking but must be fixed
dsgouda
approved these changes
Apr 29, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM will merge once CIs pass
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
…zure#5944) * Initial setup of Personalizer SDK * checking in Rank Test * Add all API tests except evalations * Consolidate tests to controller groups. * Add evaluations tests. * Adding Readme and generate.ps1 * regenerate client and fix tests * fix all tests , add sdkinfo and metadata files * fix version names * add tests proj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generated code and SDK API tests for Personalizer v1.0 preview
Spec PR links
Azure/azure-rest-api-specs#5743
Azure/azure-rest-api-specs#5777
Both Spec PRs have been merged