Skip to content

[ApiManagement] removed id validation #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erich-wang merged 1 commit into from
Jul 24, 2019
Merged

[ApiManagement] removed id validation #7010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## Microsoft.Azure.Management.ApiManagment release notes

### Changes in 4.11.0-preview

- Removed id validation on `groups`, `apis`, `products`, `users` and `backend` to unblock existing customers to onboard to new sdks

### Changes in 4.10.0-preview

- Fixed support for creating, updating Swagger, WSDL and Open Api Schema.
Expand Down
24 changes: 0 additions & 24 deletions ...agement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiDiagnosticOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -369,10 +365,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (diagnosticId == null)
{
Expand Down Expand Up @@ -620,10 +612,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (diagnosticId == null)
{
Expand Down Expand Up @@ -896,10 +884,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (diagnosticId == null)
{
Expand Down Expand Up @@ -1213,10 +1197,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (diagnosticId == null)
{
Expand Down Expand Up @@ -1477,10 +1457,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (diagnosticId == null)
{
Expand Down
20 changes: 0 additions & 20 deletions ...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueAttachmentOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -397,10 +393,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -673,10 +665,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -974,10 +962,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -1311,10 +1295,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down
20 changes: 0 additions & 20 deletions ...ement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueCommentOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -397,10 +393,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -673,10 +665,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -973,10 +961,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -1310,10 +1294,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down
24 changes: 0 additions & 24 deletions ...pimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -377,10 +373,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -631,10 +623,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -912,10 +900,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -1228,10 +1212,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down Expand Up @@ -1492,10 +1472,6 @@ internal ApiIssueOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (issueId == null)
{
Expand Down
20 changes: 0 additions & 20 deletions ...nagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,10 +398,6 @@ internal ApiOperationOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -650,10 +646,6 @@ internal ApiOperationOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -927,10 +919,6 @@ internal ApiOperationOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (parameters == null)
{
Expand Down Expand Up @@ -1245,10 +1233,6 @@ internal ApiOperationOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (parameters == null)
{
Expand Down Expand Up @@ -1510,10 +1494,6 @@ internal ApiOperationOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (ifMatch == null)
{
Expand Down
20 changes: 0 additions & 20 deletions ...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationPolicyOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -402,10 +398,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -660,10 +652,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down Expand Up @@ -945,10 +933,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (parameters == null)
{
Expand Down Expand Up @@ -1262,10 +1246,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
}
}
if (ifMatch == null)
{
Expand Down
4 changes: 0 additions & 4 deletions ...management/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiProductOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,6 @@ internal ApiProductOperations(ApiManagementClient client)
{
throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
}
if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
{
throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
}
}
if (Client.ApiVersion == null)
{
Expand Down
Loading