Skip to content

Conversation

@szimmer-dev
Copy link
Contributor

No description provided.

@szimmer-dev szimmer-dev requested a review from erich-wang as a code owner August 2, 2019 00:11
@erich-wang erich-wang self-assigned this Aug 2, 2019
@erich-wang
Copy link
Member

@szimmerMicrosoft , could you

  1. Provide the swagger spec PR related to this PR?
  2. Address the comment about AssemblyVersion

@szimmer-dev
Copy link
Contributor Author

szimmer-dev commented Aug 2, 2019

@szimmerMicrosoft , could you

  1. Provide the swagger spec PR related to this PR?
  2. Address the comment about AssemblyVersion

@erich-wang
have addressed the assembly version.

Here is the source pull request:
Azure/azure-rest-api-specs#6683

@erich-wang
Copy link
Member

Approve from my side. @hyonholee , please approve if no more comments.

@hyonholee
Copy link
Contributor

Approved. BTW, @erich-wang could you check why CI build failed with the following error? It doesn't seem to be related with this PR.

Failed to resolve SDK 'Microsoft.Build.CentralPackageVersions/2.0.36'. Package restore was successful but a package with the ID of "Microsoft.Build.CentralPackageVersions" was not installed.

@erich-wang
Copy link
Member

/azp run net - client - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hyonholee
Copy link
Contributor

Hi, @erich-wang could you merge this PR, if there is no more concern? Thanks.

@erich-wang erich-wang merged commit 95848e4 into Azure:master Aug 8, 2019
pull bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Aug 8, 2019
* Generate new compute import for SDK

* Increment minor version.

* Add the updates to the package release notes.

* Fixed assembly issue versioning.

* Add test for Scheduled events usage in the Compute .NET sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants