[AutoPR monitor/resource-manager] Add two missing "by subscription" operations for completeness and compliance

lib/services/monitorManagement/lib/models/action.js

@@ -11,7 +11,8 @@
 'use strict';
 
 /**
- * Class representing a Action.
+ * Action descriptor.
+ *
  */
 class Action {
   /**

lib/services/monitorManagement/lib/models/alertingAction.js

@@ -42,7 +42,8 @@ class AlertingAction extends models['Action'] {
    * @member {string} [trigger.metricTrigger.thresholdOperator] Evaluation
    * operation for Metric -'GreaterThan' or 'LessThan' or 'Equal'. Possible
    * values include: 'GreaterThan', 'LessThan', 'Equal'
-   * @member {number} [trigger.metricTrigger.threshold]
+   * @member {number} [trigger.metricTrigger.threshold] The threshold of the
+   * metric trigger.
    * @member {string} [trigger.metricTrigger.metricTriggerType] Metric Trigger
    * Type - 'Consecutive' or 'Total'. Possible values include: 'Consecutive',
    * 'Total'

lib/services/monitorManagement/lib/models/diagnosticSettingsResource.js

@@ -22,6 +22,8 @@ class DiagnosticSettingsResource extends models['ProxyOnlyResource'] {
    * Create a DiagnosticSettingsResource.
    * @member {string} [storageAccountId] The resource ID of the storage account
    * to which you would like to send Diagnostic Logs.
+   * @member {string} [serviceBusRuleId] The service bus rule Id of the
+   * diagnostic setting. This is here to maintain backwards compatibility.
    * @member {string} [eventHubAuthorizationRuleId] The resource Id for the
    * event hub authorization rule.
    * @member {string} [eventHubName] The name of the event hub. If none is
@@ -82,6 +84,13 @@ class DiagnosticSettingsResource extends models['ProxyOnlyResource'] {
               name: 'String'
             }
           },
+          serviceBusRuleId: {
+            required: false,
+            serializedName: 'properties.serviceBusRuleId',
+            type: {
+              name: 'String'
+            }
+          },
           eventHubAuthorizationRuleId: {
             required: false,
             serializedName: 'properties.eventHubAuthorizationRuleId',

lib/services/monitorManagement/lib/models/eventData.js

@@ -19,7 +19,7 @@ const models = require('./index');
 class EventData {
   /**
    * Create a EventData.
-   * @member {object} [authorization]
+   * @member {object} [authorization] The sender authorization information.
    * @member {string} [authorization.action] the permissible actions. For
    * instance: microsoft.support/supporttickets/write
    * @member {string} [authorization.role] the role of the user. For instance:

lib/services/monitorManagement/lib/models/index.d.ts

@@ -1126,6 +1126,8 @@ export interface LogSettings {
  *
  * @member {string} [storageAccountId] The resource ID of the storage account
  * to which you would like to send Diagnostic Logs.
+ * @member {string} [serviceBusRuleId] The service bus rule Id of the
+ * diagnostic setting. This is here to maintain backwards compatibility.
  * @member {string} [eventHubAuthorizationRuleId] The resource Id for the event
  * hub authorization rule.
  * @member {string} [eventHubName] The name of the event hub. If none is
@@ -1139,6 +1141,7 @@ export interface LogSettings {
  */
 export interface DiagnosticSettingsResource extends ProxyOnlyResource {
   storageAccountId?: string;
+  serviceBusRuleId?: string;
   eventHubAuthorizationRuleId?: string;
   eventHubName?: string;
   metrics?: MetricSettings[];
@@ -1594,7 +1597,7 @@ export interface HttpRequestInfo {
  * @constructor
  * The Azure event log entries are of type EventData
  *
- * @member {object} [authorization]
+ * @member {object} [authorization] The sender authorization information.
  * @member {string} [authorization.action] the permissible actions. For
  * instance: microsoft.support/supporttickets/write
  * @member {string} [authorization.role] the role of the user. For instance:
@@ -1983,7 +1986,7 @@ export interface CalculateBaselineResponse {
  * An alert action.
  *
  * @member {string} [actionGroupId] the id of the action group to use.
- * @member {object} [webhookProperties]
+ * @member {object} [webhookProperties] The properties of a webhook object.
  */
 export interface MetricAlertAction {
   actionGroupId?: string;
@@ -2095,7 +2098,8 @@ export interface MetricAlertResourcePatch {
  * @constructor
  * An alert status properties.
  *
- * @member {object} [dimensions]
+ * @member {object} [dimensions] An object describing the type of the
+ * dimensions.
  * @member {string} [status] status value
  * @member {date} [timestamp] UTC time when the status was checked.
  */
@@ -2116,7 +2120,8 @@ export interface MetricAlertStatusProperties {
  * @member {string} [type] The extended resource type name.
  * @member {object} [properties] The alert status properties of the metric
  * alert status.
- * @member {object} [properties.dimensions]
+ * @member {object} [properties.dimensions] An object describing the type of
+ * the dimensions.
  * @member {string} [properties.status] status value
  * @member {date} [properties.timestamp] UTC time when the status was checked.
  */
@@ -2143,6 +2148,8 @@ export interface MetricAlertStatusCollection {
  * @class
  * Initializes a new instance of the MetricDimension class.
  * @constructor
+ * Specifies a metric dimension.
+ *
  * @member {string} name Name of the dimension.
  * @member {string} operator the dimension operator.
  * @member {array} values list of dimension values.
@@ -2157,6 +2164,8 @@ export interface MetricDimension {
  * @class
  * Initializes a new instance of the MetricCriteria class.
  * @constructor
+ * Criterion to filter metrics.
+ *
  * @member {string} name Name of the criteria.
  * @member {string} metricName Name of the metric.
  * @member {string} [metricNamespace] Namespace of the metric.
@@ -2230,6 +2239,8 @@ export interface Schedule {
  * @class
  * Initializes a new instance of the Action class.
  * @constructor
+ * Action descriptor.
+ *
  * @member {string} odatatype Polymorphic Discriminator
  */
 export interface Action {
@@ -2298,10 +2309,12 @@ export interface LogSearchRuleResourcePatch {
  * @class
  * Initializes a new instance of the LogMetricTrigger class.
  * @constructor
+ * A log metrics trigger descriptor.
+ *
  * @member {string} [thresholdOperator] Evaluation operation for Metric
  * -'GreaterThan' or 'LessThan' or 'Equal'. Possible values include:
  * 'GreaterThan', 'LessThan', 'Equal'
- * @member {number} [threshold]
+ * @member {number} [threshold] The threshold of the metric trigger.
  * @member {string} [metricTriggerType] Metric Trigger Type - 'Consecutive' or
  * 'Total'. Possible values include: 'Consecutive', 'Total'
  * @member {string} [metricColumn] Evaluation of metric on a particular column
@@ -2328,7 +2341,8 @@ export interface LogMetricTrigger {
  * @member {string} [metricTrigger.thresholdOperator] Evaluation operation for
  * Metric -'GreaterThan' or 'LessThan' or 'Equal'. Possible values include:
  * 'GreaterThan', 'LessThan', 'Equal'
- * @member {number} [metricTrigger.threshold]
+ * @member {number} [metricTrigger.threshold] The threshold of the metric
+ * trigger.
  * @member {string} [metricTrigger.metricTriggerType] Metric Trigger Type -
  * 'Consecutive' or 'Total'. Possible values include: 'Consecutive', 'Total'
  * @member {string} [metricTrigger.metricColumn] Evaluation of metric on a
@@ -2386,7 +2400,8 @@ export interface AzNsActionGroup {
  * @member {string} [trigger.metricTrigger.thresholdOperator] Evaluation
  * operation for Metric -'GreaterThan' or 'LessThan' or 'Equal'. Possible
  * values include: 'GreaterThan', 'LessThan', 'Equal'
- * @member {number} [trigger.metricTrigger.threshold]
+ * @member {number} [trigger.metricTrigger.threshold] The threshold of the
+ * metric trigger.
  * @member {string} [trigger.metricTrigger.metricTriggerType] Metric Trigger
  * Type - 'Consecutive' or 'Total'. Possible values include: 'Consecutive',
  * 'Total'

lib/services/monitorManagement/lib/models/logMetricTrigger.js

@@ -11,15 +11,16 @@
 'use strict';
 
 /**
- * Class representing a LogMetricTrigger.
+ * A log metrics trigger descriptor.
+ *
  */
 class LogMetricTrigger {
   /**
    * Create a LogMetricTrigger.
    * @member {string} [thresholdOperator] Evaluation operation for Metric
    * -'GreaterThan' or 'LessThan' or 'Equal'. Possible values include:
    * 'GreaterThan', 'LessThan', 'Equal'
-   * @member {number} [threshold]
+   * @member {number} [threshold] The threshold of the metric trigger.
    * @member {string} [metricTriggerType] Metric Trigger Type - 'Consecutive'
    * or 'Total'. Possible values include: 'Consecutive', 'Total'
    * @member {string} [metricColumn] Evaluation of metric on a particular

lib/services/monitorManagement/lib/models/metricAlertAction.js

@@ -18,7 +18,7 @@ class MetricAlertAction {
   /**
    * Create a MetricAlertAction.
    * @member {string} [actionGroupId] the id of the action group to use.
-   * @member {object} [webhookProperties]
+   * @member {object} [webhookProperties] The properties of a webhook object.
    */
   constructor() {
   }

lib/services/monitorManagement/lib/models/metricAlertStatus.js

@@ -24,7 +24,8 @@ class MetricAlertStatus {
    * @member {string} [type] The extended resource type name.
    * @member {object} [properties] The alert status properties of the metric
    * alert status.
-   * @member {object} [properties.dimensions]
+   * @member {object} [properties.dimensions] An object describing the type of
+   * the dimensions.
    * @member {string} [properties.status] status value
    * @member {date} [properties.timestamp] UTC time when the status was
    * checked.

lib/services/monitorManagement/lib/models/metricAlertStatusProperties.js

@@ -17,7 +17,8 @@
 class MetricAlertStatusProperties {
   /**
    * Create a MetricAlertStatusProperties.
-   * @member {object} [dimensions]
+   * @member {object} [dimensions] An object describing the type of the
+   * dimensions.
    * @member {string} [status] status value
    * @member {date} [timestamp] UTC time when the status was checked.
    */

lib/services/monitorManagement/lib/models/metricCriteria.js

@@ -13,7 +13,8 @@
 const models = require('./index');
 
 /**
- * Class representing a MetricCriteria.
+ * Criterion to filter metrics.
+ *
  */
 class MetricCriteria {
   /**

lib/services/monitorManagement/lib/models/metricDimension.js

@@ -11,7 +11,8 @@
 'use strict';
 
 /**
- * Class representing a MetricDimension.
+ * Specifies a metric dimension.
+ *
  */
 class MetricDimension {
   /**

lib/services/monitorManagement/lib/models/triggerCondition.js

@@ -28,7 +28,8 @@ class TriggerCondition {
    * @member {string} [metricTrigger.thresholdOperator] Evaluation operation
    * for Metric -'GreaterThan' or 'LessThan' or 'Equal'. Possible values
    * include: 'GreaterThan', 'LessThan', 'Equal'
-   * @member {number} [metricTrigger.threshold]
+   * @member {number} [metricTrigger.threshold] The threshold of the metric
+   * trigger.
    * @member {string} [metricTrigger.metricTriggerType] Metric Trigger Type -
    * 'Consecutive' or 'Total'. Possible values include: 'Consecutive', 'Total'
    * @member {string} [metricTrigger.metricColumn] Evaluation of metric on a