Prevent DefaultAzureCredential changing authentication method #10349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
|
Can one of the admins verify this patch? |
xiangyan99
reviewed
Mar 24, 2020
schaabs
approved these changes
Mar 24, 2020
xiangyan99
approved these changes
Mar 24, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2020
…into shared_credential * 'master' of https://github.com/Azure/azure-sdk-for-python: Update install link [Event Hubs] Put uamqp.Message.properties into EventData.system_properties (Azure#10508) Sync eng/common directory with azure-sdk-tools repository (Azure#10531) Prevent DefaultAzureCredential changing authentication method (Azure#10349) Update Batch Data plane (Azure#10477)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2020
…into shared_credential_ta * 'master' of https://github.com/Azure/azure-sdk-for-python: Update install link [Event Hubs] Put uamqp.Message.properties into EventData.system_properties (Azure#10508) Sync eng/common directory with azure-sdk-tools repository (Azure#10531) Prevent DefaultAzureCredential changing authentication method (Azure#10349) Update Batch Data plane (Azure#10477)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2020
…re-sdk-for-python into shared_credential_search * 'shared_credential' of https://github.com/iscai-msft/azure-sdk-for-python: fixed test Update install link [Event Hubs] Put uamqp.Message.properties into EventData.system_properties (Azure#10508) Sync eng/common directory with azure-sdk-tools repository (Azure#10531) Prevent DefaultAzureCredential changing authentication method (Azure#10349) Update Batch Data plane (Azure#10477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this,
DefaultAzureCredential.get_tokeniterates over its collection of included credentials only when none has provided a token. After an included credential provides a token,DefaultAzureCredential.get_tokenalways uses that credential directly. In addition to being more efficient this prevents unexpected changes of identity.