Skip to content

Conversation

@xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from bryevdv May 21, 2020 20:44
@xiangyan99
Copy link
Member Author

#11514

@xiangyan99 xiangyan99 requested a review from bryevdv May 22, 2020 00:32
@xiangyan99 xiangyan99 requested review from heaths and rakshith91 May 22, 2020 15:33
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look in details, but the approach make sense, if test are green go for it :)

@xiangyan99 xiangyan99 merged commit 37eea83 into master May 22, 2020
@xiangyan99 xiangyan99 deleted the search_synonym_map branch May 22, 2020 18:18
iscai-msft added a commit that referenced this pull request May 26, 2020
…into feature/text_analytics_v3.0

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Release azure mgmt containerregistry (#11460)
  Prepare core 1.6.0 on master (#11610)
  Add force parameter to SwaggerToSdk CLI (#11609)
  LRO continuation_token (#10801)
  Remove unecessary import (#11606)
  Fix Cleanup failing on 3.8.3 (#11607)
  remove DataSourceCredentials (#11605)
  Search synonym map (#11590)
  Fix copy tests (#11594)
  Make use_training_labels positional required (#11529)
  Search refactoring 2 (#11584)
  Search refactoring 1 (#11572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants