Respect nbf and exp in local encrypt/wrap operations #11953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
KeyVault
Client
iscai-msft
approved these changes
Jun 10, 2020
| return | ||
|
|
||
| now = datetime.now(_UTC) | ||
| if (nbf and exp) and not nbf <= now <= exp: |
Contributor
There was a problem hiding this comment.
just one quick question: are you sure that you can use a key on its expiration date? Makes sense to me, just want to clarify because it can get a bit confusing given an expiration date whether you can't use it on that date, or after that date
Member
There was a problem hiding this comment.
As long as your datetime has second (or lower) resolution, it really wouldn't matter much.
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: (21 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encrypting locally,
CryptographyClientshould enforce key validity periods with Key Vault's semantics to ensure that a user can't encrypt something Key Vault would refuse to decrypt. This PR adds that enforcement to encrypt and wrap operations. It should apply to sign as well, butCryptographyClientcurrently doesn't sign locally.