Skip to content

[Storage][STG73]ChangeLog #12261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiafu-msft wants to merge 3 commits into from
Closed

[Storage][STG73]ChangeLog #12261

xiafu-msft wants to merge 3 commits into from

Conversation

@xiafu-msft
Copy link
Contributor

@xiafu-msft xiafu-msft commented Jun 30, 2020

No description provided.

annatisch
annatisch reviewed Jul 1, 2020
View reviewed changes
sdk/storage/azure-storage-file-datalake/setup.py Outdated
Copy link
Member

@annatisch annatisch Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a beta/preview? The version change above is stable, and the only change in the changelog is the block size.

Copy link
Contributor Author

@xiafu-msft xiafu-msft Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make the version to 12.1.0b (commented above) let me know if you have any concern!!

annatisch
annatisch reviewed Jul 1, 2020
View reviewed changes
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_version.py Outdated
Copy link
Member

@annatisch annatisch Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a preview version.

Copy link
Contributor Author

@xiafu-msft xiafu-msft Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really appreciated you've reviewed this pr!!!!!
yeah I agree with you! when I had the pr, there wasn't a final decision made ^_^

xiafu-msft
xiafu-msft commented Jul 7, 2020
View reviewed changes
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_version.py Outdated
Copy link
Contributor Author

@xiafu-msft xiafu-msft Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make it 12.1.0b, let me know if you feel it's weird, I just feel not confident about Jumbo blob feature, since with max_single_put_size equals 64MB, user always get timeout .... I feel panic about max_single_put_size equals 5GB

@xiafu-msft xiafu-msft marked this pull request as ready for review July 7, 2020 22:41
@xiafu-msft xiafu-msft changed the base branch from master to feature/storage-stg73 July 7, 2020 23:03
@xiafu-msft xiafu-msft requested a review from annatisch July 7, 2020 23:04
@xiafu-msft xiafu-msft mentioned this pull request Jul 7, 2020
Merged
@xiafu-msft xiafu-msft closed this Jul 7, 2020
@xiafu-msft xiafu-msft deleted the stg73-changelog branch July 7, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

@annatisch annatisch Awaiting requested review from annatisch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiafu-msft @annatisch