Skip to content

[ServiceBus] Message/ReceivedMessage Properties alignment with other languages #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunhaoling merged 17 commits into from
Jul 18, 2020
Merged

[ServiceBus] Message/ReceivedMessage Properties alignment with other languages #12451

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5d8f36c
additional properties
yunhaoling Jul 8, 2020
3efdc55
add properties and reorder them
yunhaoling Jul 9, 2020
5203876
add comment and internalize variables
yunhaoling Jul 14, 2020
9265792
update changelog and fix mypy pylint
yunhaoling Jul 14, 2020
91ea250
fix pylint
yunhaoling Jul 14, 2020
40d81b7
fix pylint
yunhaoling Jul 14, 2020
6cc8adf
update impl, sample, livetest and doc
yunhaoling Jul 15, 2020
29772e0
Merge remote-tracking branch 'central/master' into sb-message-properties
yunhaoling Jul 15, 2020
1cce42a
fix pylint
yunhaoling Jul 15, 2020
9c9e4d3
remove partition_id
yunhaoling Jul 15, 2020
666ae27
fix merge problem
yunhaoling Jul 15, 2020
0882f13
update according to comment
yunhaoling Jul 16, 2020
b3677b2
fixed bug in previous implementation when setting annotation multiple…
yunhaoling Jul 16, 2020
5161d7f
fix pylint
yunhaoling Jul 16, 2020
6759eb1
fix py2.7 unittest
yunhaoling Jul 16, 2020
888fc93
add settled back first
yunhaoling Jul 17, 2020
39c0af2
add session_id and reply_to_session_id assertion
yunhaoling Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix pylint
  • Loading branch information
@yunhaoling
yunhaoling committed Jul 14, 2020
commit 91ea2500cf8147a82dbb8d67ce4e463c0bb0ffb5
6 changes: 3 additions & 3 deletions sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def content_type(self, val):
@property
def correlation_id(self):
# type: () -> str
# pylint: disable=protected-access
# pylint: line-too-long
"""The correlation identifier.

Allows an application to specify a context for the message for the purposes of correlation, for example
Expand Down Expand Up @@ -341,7 +341,7 @@ def message_id(self, val):
@property
def reply_to(self):
# type: () -> str
# pylint: disable=protected-access
# pylint: line-too-long
"""The address of an entity to send replies to.

This optional and application-defined value is a standard way to express a reply path to the receiver of
Expand All @@ -363,7 +363,7 @@ def reply_to(self, val):
@property
def reply_to_session_id(self):
# type: () -> str
# pylint: disable=protected-access
# pylint: line-too-long
"""The session identifier augmenting the `reply_to` address.

This value augments the `reply_to` information and specifies which session id should be set for the reply
Expand Down