Handle missing certs model properties in 2016-10-01 #13129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
KeyVault
Client
iscai-msft
approved these changes
Aug 17, 2020
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
thanks for doing this!
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 17, 2020
…into get_certs_2016 * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) Type inference (Azure#12980) Add azure-ai-anomalydetector to error code 5 ignored list (Azure#13131) Handle missing model properties in Key Vault 2016-10-01 (Azure#13129) fix aad test so it runs locally (Azure#13127) Suppress errors in anomoly detector for now. (Azure#13141) Anomaly Detector V1, track2 generator (Azure#12931) [formrecognizer] Add `kind` to FormElement (Azure#13079) Regenerate code from connie's swagger change (Azure#12979) Update async (Azure#12978) Move get_access_conditions to _serialize.py (Azure#13105) [Storage][DataLake]Update Min Dependency (Azure#13108) Restore user authentication API from 1.4.0b7 (Azure#13070) [Storage][FileShare]ChangeLog update (Azure#13103) remove locale (Azure#13102) [Storage][Blob]ChangeLog Update (Azure#13081) Fixed etag bug (Azure#13078) [Storage][Blob]Fix live test and if tags bug (Azure#13054) [Storage][Blob][Batch]Support batch delete empty blob list (Azure#13029) [Storage][Blob][Bug]Support parsing blob url with '/' in blob name (Azure#12619) [formrecognizer] add api version enum (Azure#12888) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Key Vault API version 2016-10-01, two models are missing attributes added in version 7.0:
Code for wrapping generated models in hand-written ones doesn't handle this gracefully, raising
AttributeError. This PR makes the code tolerant of these missing attributes and adds a test to exercise it. The test is a medium-term thing. For the long run we need a better way to test multiple versions, something likepytest.mark.parametrizethat runs test cases with a client for each supported service version.There's at least one other issue preventing
CertificateClientfrom fully supporting 2016-10-01: #13122.