[ServiceBus] Test and failure improvements #13345

KieranBrantnerMagee · 2020-08-26T19:47:25Z

A smattering of small test improvements.

ensure incorrect_queue_conn_str test validates success and failure cases and consistency of different entry points.
ensure specificity of authorization/authenication errors
Begin adding "raises" stanzas to docstrings.
normalize convert_connection_string_to_kwargs to throw AuthenticationError on misaligned entity_path
fix flaky scheduled tests: both moving away from the receive_messages calls in tests, and making scheduled vs enqueue time a <= relationshi rather than ==.
similarly, if we're using the "source of truth" internal time for max wait time valdiation, must be<= since the milliseconds can actually be EXACT.

A smattering of small test improvements. - ensure incorrect_queue_conn_str test validates success and failure cases and consistency of different entry points. - ensure specificity of authorization/authenication errors - Begin adding "raises" stanzas to docstrings. - normalize convert_connection_string_to_kwargs to throw AuthenticationError on misaligned entity_path - fix flaky scheduled tests: both moving away from the receive_messages calls in tests, and making scheduled vs enqueue time a <= relationshi rather than ==. - similarly, if we're using the "source of truth" internal time for max wait time valdiation, must be<= since the milliseconds can actually be EXACT.

KieranBrantnerMagee · 2020-08-26T19:48:15Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-26T19:48:23Z

Azure Pipelines successfully started running 1 pipeline(s).

Add missing ServiceBusAuthorizationError as import for more precise tests.

KieranBrantnerMagee · 2020-08-27T00:03:11Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-27T00:03:21Z

Azure Pipelines successfully started running 1 pipeline(s).

KieranBrantnerMagee · 2020-08-27T00:12:39Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-27T00:12:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Fix test by making for loop properly async when swapping in the iterator.

KieranBrantnerMagee · 2020-08-27T02:29:19Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-27T02:29:28Z

Azure Pipelines successfully started running 1 pipeline(s).

KieranBrantnerMagee · 2020-08-27T03:39:53Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-27T03:40:17Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/servicebus/azure-servicebus/CHANGELOG.md

sdk/servicebus/azure-servicebus/azure/servicebus/__init__.py

sdk/servicebus/azure-servicebus/tests/async_tests/test_queues_async.py

remove session from aio (adjust changelog) re-adjust test to use batch as intended.

KieranBrantnerMagee · 2020-08-31T17:11:22Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-31T17:11:32Z

Azure Pipelines successfully started running 1 pipeline(s).

…th type hinting that uses the public path currently. Should do this while adjusting to try and use internal paths while keeping an eye on typechecking; will be larger work.

KieranBrantnerMagee · 2020-08-31T17:47:42Z

/azp run python - servicebus - tests

azure-pipelines · 2020-08-31T17:47:52Z

Azure Pipelines successfully started running 1 pipeline(s).

…into add_redacted_text * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] add bing_id property to LinkedEntity class (Azure#13446) fix typing for paging methods (Azure#13410) [text analytics] add domain_filter param (Azure#13451) fix issue Azure#11658 for is_valid_resource_id (Azure#11709) added create_table_if_not_exists method to table service client (Azure#13385) [ServiceBus] Test and failure improvements (Azure#13345) Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275) Switch retry (Azure#13264) [ServiceBus] ServiceBusClient close spawned children (Azure#13077) fixing version issue by not overwriting the version with the semantic… (Azure#13411)

…into expose_parse_vault_id * 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits) [text analytics] add versionadded sphinx documentation (Azure#13450) [text analytics] add bing_id property to LinkedEntity class (Azure#13446) fix typing for paging methods (Azure#13410) [text analytics] add domain_filter param (Azure#13451) fix issue Azure#11658 for is_valid_resource_id (Azure#11709) added create_table_if_not_exists method to table service client (Azure#13385) [ServiceBus] Test and failure improvements (Azure#13345) Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275) Switch retry (Azure#13264) [ServiceBus] ServiceBusClient close spawned children (Azure#13077) fixing version issue by not overwriting the version with the semantic… (Azure#13411) clean up reference and tests (Azure#13412) Consistent returns (Azure#13245) [text analytics] return None for offset and length for v3.0 (Azure#13382) edit all authentication files and add a test (Azure#13355) Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218) [text analytics] add string-index-type support (Azure#13378) [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383) Send spec (Azure#13143) Anomaly Detector 3.0.0b2 release (Azure#13351) ...

…into link_om_sample * 'master' of https://github.com/Azure/azure-sdk-for-python: (23 commits) Int32 serialization (Azure#13452) add output to opinion mining sample (Azure#13494) Add Document w/ Eng Sys Checks (Azure#13492) update version (Azure#13495) Remove resources post test (Azure#13379) bing_id -> bing_entity_search_api_id (Azure#13491) [EventGrid] Read me + improve docstrings (Azure#13484) Build AuthenticationRecords from ADFS identity tokens (Azure#13341) Support Subject Name/Issuer authentication (Azure#13350) Add KeyVaultAccessControlClient for data plane RBAC (Azure#13372) [text analytics] Add redacted_text (Azure#13449) add python sdk sample (Azure#13338) [text analytics] add versionadded sphinx documentation (Azure#13450) [text analytics] add bing_id property to LinkedEntity class (Azure#13446) fix typing for paging methods (Azure#13410) [text analytics] add domain_filter param (Azure#13451) fix issue Azure#11658 for is_valid_resource_id (Azure#11709) added create_table_if_not_exists method to table service client (Azure#13385) [ServiceBus] Test and failure improvements (Azure#13345) Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275) ...

KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 26, 2020

KieranBrantnerMagee added this to the [2020] September milestone Aug 26, 2020

KieranBrantnerMagee requested review from YijunXieMS, annatisch, rakshith91 and yunhaoling August 26, 2020 19:47

KieranBrantnerMagee self-assigned this Aug 26, 2020

KieranBrantnerMagee changed the title ~~Small but important: does not import ServiceBusSession any more.~~ [ServiceBus] Test and failure improvements Aug 26, 2020

Update test_sb_client.py

09722ae

Add missing ServiceBusAuthorizationError as import for more precise tests.

Update test_queues_async.py

57a956f

Fix test by making for loop properly async when swapping in the iterator.

KieranBrantnerMagee marked this pull request as ready for review August 27, 2020 17:25

yunhaoling reviewed Aug 29, 2020

View reviewed changes

sdk/servicebus/azure-servicebus/CHANGELOG.md Outdated Show resolved Hide resolved

yunhaoling reviewed Aug 29, 2020

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/__init__.py Show resolved Hide resolved

yunhaoling reviewed Aug 29, 2020

View reviewed changes

sdk/servicebus/azure-servicebus/tests/async_tests/test_queues_async.py Outdated Show resolved Hide resolved

KieranBrantnerMagee added 2 commits August 31, 2020 00:53

PR comments;

f82ac9e

remove session from aio (adjust changelog) re-adjust test to use batch as intended.

merge from upstream

850173c

KieranBrantnerMagee requested a review from yunhaoling August 31, 2020 17:11

KieranBrantnerMagee added 2 commits August 31, 2020 10:27

readd servicebussession on Adam's good point that it may interfere wi…

a0cca11

…th type hinting that uses the public path currently. Should do this while adjusting to try and use internal paths while keeping an eye on typechecking; will be larger work.

merge from upstream master

bbe9dd2

yunhaoling approved these changes Aug 31, 2020

View reviewed changes

KieranBrantnerMagee merged commit c77746b into Azure:master Aug 31, 2020

[ServiceBus] Test and failure improvements #13345

[ServiceBus] Test and failure improvements #13345

Uh oh!

Conversation

KieranBrantnerMagee commented Aug 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KieranBrantnerMagee commented Aug 26, 2020

Uh oh!

azure-pipelines bot commented Aug 26, 2020

Uh oh!

KieranBrantnerMagee commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

KieranBrantnerMagee commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

KieranBrantnerMagee commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

KieranBrantnerMagee commented Aug 27, 2020

Uh oh!

azure-pipelines bot commented Aug 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KieranBrantnerMagee commented Aug 31, 2020

Uh oh!

azure-pipelines bot commented Aug 31, 2020

Uh oh!

KieranBrantnerMagee commented Aug 31, 2020

Uh oh!

azure-pipelines bot commented Aug 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KieranBrantnerMagee commented Aug 26, 2020 •

edited

Loading