-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[formrecognizer] composed model #14029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
549d69b
initial model compose
kristapratico dc7fe09
fix tests for composed model and repr
kristapratico 9c404a3
mypy
kristapratico b2a8502
fix comments
kristapratico 45a10d5
add fixmes
kristapratico 58cbecb
set form_type on CustomFormSubmodel correctly
kristapratico 380be3c
fix training tests
kristapratico 82f80ff
merge master
kristapratico f5cd77d
remove error map/cont token from compose model
kristapratico f4537ac
add composed model tests
kristapratico 3b598bd
adding more tests for new fields
kristapratico 7cc601f
updating readmes/changelog
kristapratico f80ab2b
small fix
kristapratico 3a9e729
update sample to be more consistent with .NET
kristapratico 02208d0
add api version table to readme
kristapratico 24b5380
add tests requested in feedback
kristapratico 9307315
merge master
kristapratico 5a70733
raise better error for multiapi
kristapratico 6919fb9
some docs feedback
kristapratico f63c6d7
testing feedback
kristapratico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
small fix
- Loading branch information
commit f80ab2b718f188bd98c58117ed996dda067b97b0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be misleading to asssign
creation time = model.training_started_onas we neever train a composed molde?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
talked to @maririos about this and we decided to have the output text indicate that the composed model is being created, since like you said, a composed model is not trained. It's unfortunate that we renamed this property like this, so the best we can do is communicate what it's actually doing over samples.