Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small fix
  • Loading branch information
kristapratico committed Oct 6, 2020
commit f80ab2b718f188bd98c58117ed996dda067b97b0
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,8 @@ class CustomFormSubmodel(object):
is generated for each field.
:vartype fields: dict[str, ~azure.ai.formrecognizer.CustomFormModelField]
:ivar str form_type: Type of form this submodel recognizes.
.. versionadded:: v2.1-preview
The *model_id* property
"""
def __init__(self, **kwargs):
self.model_id = kwargs.get("model_id", None)
Expand Down Expand Up @@ -788,6 +790,8 @@ class TrainingDocumentInfo(object):
List of any errors for document.
:ivar str model_id:
The model ID that used the document to train.
.. versionadded:: v2.1-preview
The *model_id* property
"""

def __init__(self, **kwargs):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
FILE: sample_create_composed_model_async.py

DESCRIPTION:
This sample demonstrates how to create a composite model using existing custom models that
This sample demonstrates how to create a composed model using existing custom models that
were trained with labels.

USAGE:
Expand Down Expand Up @@ -46,7 +46,7 @@ async def create_composed_model_async(self):
# Custom model information
print("Model ID: {}".format(model.model_id))
print("Model display name: {}".format(model.display_name))
print("Is this a composite model?: {}".format(model.properties.is_composed_model))
print("Is this a composed model?: {}".format(model.properties.is_composed_model))
print("Status: {}".format(model.status))
print("Composed model creation started on: {}".format(model.training_started_on))
print("Creation completed on: {}".format(model.training_completed_on))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ async def manage_custom_models(self):
print("\nModel ID: {}".format(custom_model.model_id))
print("Status: {}".format(custom_model.status))
print("Model display name: {}".format(custom_model.display_name))
print("Is this a composite model?: {}".format(custom_model.properties.is_composed_model))
print("Is this a composed model?: {}".format(custom_model.properties.is_composed_model))
print("Training started on: {}".format(custom_model.training_started_on))
print("Training completed on: {}".format(custom_model.training_completed_on))
# [END get_custom_model_async]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async def train_model_with_labels(self):
print("Model ID: {}".format(model.model_id))
print("Status: {}".format(model.status))
print("Model display name: {}".format(model.display_name))
print("Is this a composite model?: {}".format(model.properties.is_composed_model))
print("Is this a composed model?: {}".format(model.properties.is_composed_model))
print("Training started on: {}".format(model.training_started_on))
print("Training completed on: {}".format(model.training_completed_on))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
FILE: sample_create_composed_model.py

DESCRIPTION:
This sample demonstrates how to create a composite model using existing custom models that
This sample demonstrates how to create a composed model using existing custom models that
were trained with labels.

USAGE:
Expand Down Expand Up @@ -44,7 +44,7 @@ def create_composed_model(self):
# Custom model information
print("Model ID: {}".format(model.model_id))
print("Model display name: {}".format(model.display_name))
print("Is this a composite model?: {}".format(model.properties.is_composed_model))
print("Is this a composed model?: {}".format(model.properties.is_composed_model))
print("Status: {}".format(model.status))
print("Composed model creation started on: {}".format(model.training_started_on))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be misleading to asssign creation time = model.training_started_on as we neever train a composed molde?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked to @maririos about this and we decided to have the output text indicate that the composed model is being created, since like you said, a composed model is not trained. It's unfortunate that we renamed this property like this, so the best we can do is communicate what it's actually doing over samples.

print("Creation completed on: {}".format(model.training_completed_on))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def manage_custom_models(self):
print("\nModel ID: {}".format(custom_model.model_id))
print("Status: {}".format(custom_model.status))
print("Model display name: {}".format(custom_model.display_name))
print("Is this a composite model?: {}".format(custom_model.properties.is_composed_model))
print("Is this a composed model?: {}".format(custom_model.properties.is_composed_model))
print("Training started on: {}".format(custom_model.training_started_on))
print("Training completed on: {}".format(custom_model.training_completed_on))
# [END get_custom_model]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def train_model_with_labels(self):
print("Model ID: {}".format(model.model_id))
print("Status: {}".format(model.status))
print("Model display name: {}".format(model.display_name))
print("Is this a composite model?: {}".format(model.properties.is_composed_model))
print("Is this a composed model?: {}".format(model.properties.is_composed_model))
print("Training started on: {}".format(model.training_started_on))
print("Training completed on: {}".format(model.training_completed_on))

Expand Down