Skip to content

Resolve Failing Documentation Build for azure-mgmt-core #14239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 6 commits into from
Oct 5, 2020
Merged

Resolve Failing Documentation Build for azure-mgmt-core #14239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
334fc41
properly update the dev versioning requirements for packages
scbedd Oct 4, 2020
3a768f9
got it
scbedd Oct 4, 2020
8c64001
add only the blob-changefeed override due to outdated req on azure-st…
scbedd Oct 5, 2020
aae5566
update regression to update the local versions of the package to MATC…
scbedd Oct 5, 2020
d7edadf
resolve falty logic causing dev build to always be true.
scbedd Oct 5, 2020
db62f30
set dev-build so that the files on disk match the expected version th…
scbedd Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve falty logic causing dev build to always be true.
  • Loading branch information
@scbedd
scbedd committed Oct 5, 2020
commit d7edadf4abe6c61941cf2f70693bb678d32cbfe4
5 changes: 3 additions & 2 deletions eng/tox/sanitize_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def get_version(pkg_name):
# strip dev build number so we can check if package exists in PyPI and replace

version_obj = Version(version)
if version_obj.pre[0] == DEV_BUILD_IDENTIFIER:
version = version_obj.base_version
if version_obj.pre:
if version_obj.pre[0] == DEV_BUILD_IDENTIFIER:
version = version_obj.base_version

return version
else:
Expand Down
2 changes: 1 addition & 1 deletion scripts/devops_tasks/build_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,4 @@ def verify_update_package_requirement(pkg_root):
target_dir = root_dir

targeted_packages = process_glob_string(args.glob_string, target_dir, args.package_filter_string)
build_packages(targeted_packages, args.distribution_directory, args.is_dev_build)
build_packages(targeted_packages, args.distribution_directory, bool(args.is_dev_build))