Addressing comments

sdk/monitor/opentelemetry-exporter-azuremonitor/opentelemetry/exporter/azuremonitor/export/__init__.py

@@ -162,6 +162,7 @@ def _is_retryable_code(self, response_code: int) -> bool:
         Determine if response is retryable
         """
         if response_code in (
+            206,  # Retriable
             408,  # Timeout
             429,  # Throttle, too Many Requests
             439,  # Quota, too Many Requests over extended time

sdk/monitor/opentelemetry-exporter-azuremonitor/opentelemetry/exporter/azuremonitor/export/trace/__init__.py

@@ -39,12 +39,7 @@ def __init__(self, **options):
 
     def export(self, spans: Sequence[Span]) -> SpanExportResult:
         envelopes = list(map(self._span_to_envelope, spans))
-        envelopes = list(
-            map(
-                lambda x: x,
-                self._apply_telemetry_processors(envelopes),
-            )
-        )
+        envelopes = self._apply_telemetry_processors(envelopes)
         try:
             result = self._transmit(envelopes)
             if result == ExportResult.FAILED_RETRYABLE:
@@ -57,8 +52,6 @@ def export(self, spans: Sequence[Span]) -> SpanExportResult:
             logger.exception("Exception occurred while exporting the data.")
             return get_trace_export_result(ExportResult.FAILED_NOT_RETRYABLE)
 
-    # pylint: disable=too-many-statements
-    # pylint: disable=too-many-branches
     def _span_to_envelope(self, span: Span) -> TelemetryItem:
         if not span:
             return None
@@ -70,8 +63,6 @@ def _span_to_envelope(self, span: Span) -> TelemetryItem:
 # pylint: disable=too-many-statements
 # pylint: disable=too-many-branches
 def convert_span_to_envelope(span: Span) -> TelemetryItem:
-    if not span:
-        return None
     envelope = TelemetryItem(
         name="",
         instrumentation_key="",
@@ -80,8 +71,6 @@ def convert_span_to_envelope(span: Span) -> TelemetryItem:
     )
     envelope.tags["ai.operation.id"] = "{:032x}".format(span.context.trace_id)
     parent = span.parent
-    if isinstance(parent, Span):
-        parent = parent.context
     if parent:
         envelope.tags["ai.operation.parentId"] = "{:016x}".format(
             parent.span_id

sdk/monitor/opentelemetry-exporter-azuremonitor/opentelemetry/exporter/azuremonitor/options.py

@@ -136,7 +136,7 @@ def _validate_instrumentation_key(self) -> None:
             raise ValueError("Instrumentation key cannot be none or empty.")
         match = uuid_regex_pattern.match(self.instrumentation_key)
         if not match:
-            raise ValueError("Invalid instrumentation key.")
+            raise ValueError("Invalid instrumentation key. It should be a valid UUID.")
 
 
 def parse_connection_string(connection_string) -> typing.Dict: