[Blob] Added support for container SAS on batch operations #16211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
tasherif-msft
added
the
feature-request
xiafu-msft
reviewed
Jan 16, 2021
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py
Outdated
Show resolved
Hide resolved
xiafu-msft
reviewed
Jan 16, 2021
.../azure-storage-blob/tests/recordings/test_container.test_batch_blobs_with_container_sas.yaml
Outdated
Show resolved
Hide resolved
tasherif-msft
force-pushed
the
scoped-batch
branch
from
e45009d to
2a3146a
Compare
xiafu-msft
reviewed
Jan 21, 2021
xiafu-msft
approved these changes
Jan 22, 2021
tasherif-msft
changed the title
tasherif-msft
added a commit
that referenced
this pull request
Feb 3, 2021
* new swagger * fixed OrMetadata * added new version * Added Container Rename (Blobs & Datalake) and Container Restore (Datalake) (#16088) * generated container rename * ormetadata * added sync and async method for * added all missing methods * added all missing methods * added kwargs * generated from main swagger branch * swagger change * downgraded version * added rename_container sync and async tests * added all tests and fixed filesystems models * fixing recordings * removed uselesss param * fixed failing test * fixed bad import * [Blob] Added support for container SAS on batch operations (#16211) * generated * Added support for container SAS for batch operations * fixed tests and made method more generic * pylint * added canadacentral * added canadacentral * Delete test_container_async.test_batch_blobs_with_container_sas.yaml recording is not used ^_^ * Delete test_container.test_batch_blobs_with_container_sas.yaml * manually fixed test * manually fixed test Co-authored-by: Xiaoxi Fu <[email protected]> * added missing params * STG76 Archboard cleanup + additional rename methods (#16431) * Arch board clean up * fixed tests * playback only tests * privated rename_container * privated rename filesystem * added all missing apis * added all missing apis * fixed failing test * removed version from docstrings * skipped tests Co-authored-by: Xiaoxi Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.