Skip to content

add custom policy #17340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 8 commits into from
Mar 25, 2021
Merged

add custom policy #17340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c2ca12e
add custom policy
xiangyan99 Mar 15, 2021
4753c30
updates
xiangyan99 Mar 15, 2021
ee4677e
rename arguments
xiangyan99 Mar 16, 2021
bcf286f
udpates
xiangyan99 Mar 18, 2021
7fb21c0
update
xiangyan99 Mar 22, 2021
2ca0585
update
xiangyan99 Mar 22, 2021
a30224a
update
xiangyan99 Mar 22, 2021
1cba725
update tests
xiangyan99 Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates
  • Loading branch information
@xiangyan99
xiangyan99 committed Mar 15, 2021
commit 4753c3021d91dea1b41455c3500ca4c982c5b8f0
4 changes: 2 additions & 2 deletions sdk/core/azure-core/azure/core/_pipeline_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use
ContentDecodePolicy(**kwargs)
]
if non_retriable_policies:
if isinstance(non_retriable_policies, HTTPPolicy) or isinstance(non_retriable_policies, SansIOHTTPPolicy):
if isinstance(non_retriable_policies, (HTTPPolicy, SansIOHTTPPolicy)):
policies.append(non_retriable_policies)
else:
for policy in non_retriable_policies:
Expand All @@ -131,7 +131,7 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use
config.authentication_policy,
config.custom_hook_policy]
if retriable_policies:
if isinstance(retriable_policies, HTTPPolicy) or isinstance(retriable_policies, SansIOHTTPPolicy):
if isinstance(retriable_policies, (HTTPPolicy, SansIOHTTPPolicy)):
policies.append(retriable_policies)
else:
for policy in retriable_policies:
Expand Down
6 changes: 2 additions & 4 deletions sdk/core/azure-core/azure/core/_pipeline_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use
ContentDecodePolicy(**kwargs)
]
if non_retriable_policies:
if isinstance(non_retriable_policies, AsyncHTTPPolicy) \
or isinstance(non_retriable_policies, SansIOHTTPPolicy):
if isinstance(non_retriable_policies, (AsyncHTTPPolicy, SansIOHTTPPolicy)):
policies.append(non_retriable_policies)
else:
for policy in non_retriable_policies:
Expand All @@ -135,8 +134,7 @@ def _build_pipeline(self, config, **kwargs): # pylint: disable=no-self-use
config.custom_hook_policy
]
if retriable_policies:
if isinstance(retriable_policies, AsyncHTTPPolicy) \
or isinstance(retriable_policies, SansIOHTTPPolicy):
if isinstance(retriable_policies, (AsyncHTTPPolicy, SansIOHTTPPolicy)):
policies.append(retriable_policies)
else:
for policy in retriable_policies:
Expand Down